Bug 41052
Summary: | Error message when allocation group size too big is misleading | ||
---|---|---|---|
Product: | File System | Reporter: | linuxteer |
Component: | XFS | Assignee: | XFS Guru (xfs-masters) |
Status: | CLOSED INVALID | ||
Severity: | low | CC: | aicacaten, alan, sandeen |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | RHEL version 6.1 (2.6.32-131.0.15.el6.x86_64) | Subsystem: | |
Regression: | No | Bisected commit-id: |
Description
linuxteer
2011-08-12 22:26:29 UTC
Closing - RHEL bug not upstream kernel tested Bug exists upstream too, but anyway, RHEL bug at https://bugzilla.redhat.com/show_bug.cgi?id=730433 Fixed by commit ddf12ea5dc56a728f24d24c5d7403c3412b40b86 Author: Eric Sandeen <sandeen@redhat.com> Date: Wed Mar 28 22:23:11 2012 -0500 mkfs.xfs: print std info if agcount makes agsize out of bounds When specifying a too-small agcount with stripe geometry, mkfs.xfs can fail with a somewhat unexpected message: $ mkfs.xfs -f -d file,name=fsfile,size=9764864000b,agcount=31,su=512k,sw=20 Allocation group size (314995613) is not a multiple of the stripe unit (128) This strikes me as especially odd because normally, mkfs.xfs tries to fix up the agsize to be a stripe multiple. The only way we get to the above error message is if ag _size_ is out of bounds; exiting with an error about alignment rather than about size seems odd. Maybe below is too clever, but if by the time we've decided that agsize is out of bounds after rounding it both up and down, as necessary, to get to a stripe-width multiple, calling validate_ag_geometry() will give us the same standard message as if we had specified no stripe geometry: $ mkfs/mkfs.xfs -f -d file,name=fsfile,size=9764864000b,agcount=31,su=512k,sw=20 agsize (314995613b) too big, maximum is 268435455 blocks Usage: mkfs.xfs ... $ mkfs/mkfs.xfs -f -d file,name=fsfile,size=9764864000b,agcount=31 agsize (314995613b) too big, maximum is 268435455 blocks Usage: mkfs.xfs ... Also, tidy up error message to explicitly state "blocks" not "b" Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Dave Chinner <dchinner@redhat.com> |