Bug 40862

Summary: Cannot change brightness on laptop with ATI Radeon 6470M
Product: ACPI Reporter: Vasilis Lourdas (bugs)
Component: Power-VideoAssignee: Lan Tianyu (tianyu.lan)
Status: CLOSED CODE_FIX    
Severity: normal CC: pali, rb, richlv, rui.zhang, tianyu.lan, tomaz.solc
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 3.0.0, 3.0.1 Subsystem:
Regression: No Bisected commit-id:
Attachments: acpidump
dmesg output

Description Vasilis Lourdas 2011-08-10 13:44:50 UTC
When I press Fn+F9 or F10 which are the keyboard buttons to decrease/increase the screen brightness of my HP Probook 6560b laptop, nothing happens.

acpi_listen reports:

video/brightnessdown BRTDN 00000087 00000000
video/brightnessdown BRTDN 00000087 00000000
video/brightnessup BRTUP 00000086 00000000
video/brightnessup BRTUP 00000086 00000000

/var/log/messages shows:

Aug 10 16:41:04 localhost dbus[2038]: [system] Successfully activated service 'org.kde.powerdevil.backlighthelper'
Aug 10 16:41:06 localhost logger: ACPI event unhandled: video/brightnessdown BRTDN 00000087 00000000
Aug 10 16:41:09 localhost logger: ACPI event unhandled: video/brightnessup BRTUP 00000086 00000000
Aug 10 16:41:10 localhost logger: ACPI event unhandled: video/brightnessup BRTUP 00000086 00000000
Aug 10 16:41:18 localhost logger: ACPI event unhandled: battery PNP0C0A:00 00000080 00000001
Aug 10 16:42:23 localhost logger: ACPI event unhandled: battery PNP0C0A:00 00000080 00000001

I'm using x86_64 kernel from Gentoo packages (gentoo-sources). The issue persists both in kernels 3.0.0 and 3.0.1.
Comment 1 Lan Tianyu 2011-08-11 12:18:13 UTC
Have you tried "echo <number> > /sys/class/backlight/acpi_video0/brightness"?

Please attach the output of acpidump and dmesg.
Comment 2 Vasilis Lourdas 2011-08-11 17:05:49 UTC
(In reply to comment #1)
> Have you tried "echo <number> > /sys/class/backlight/acpi_video0/brightness"?

No, it does not work.

> Please attach the output of acpidump and dmesg.

I will add attachments of both.
Comment 3 Vasilis Lourdas 2011-08-11 17:07:27 UTC
Created attachment 68592 [details]
acpidump
Comment 4 Vasilis Lourdas 2011-08-11 17:08:02 UTC
Created attachment 68602 [details]
dmesg output
Comment 5 Lan Tianyu 2011-08-15 01:25:10 UTC
I think you can bisect bisect between 2.6.37 or earlier and 3.0.1 to identify whether the bug is a regression.
Comment 6 Pali Rohár 2012-01-17 18:25:43 UTC
Same problem in reported bug 41112
Comment 7 Zhang Rui 2012-01-18 05:32:22 UTC
I don't think this is a regression.

Vasileios and Pali,
Can you please verify if the problem still exists in the latest upstream
kernel?
Comment 8 Pali Rohár 2012-01-18 11:47:53 UTC
I have linux kernel
Linux Pali-EliteBook 3.2.0-4-generic #10-Ubuntu SMP Wed Dec 14 02:11:20 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux
and problem is still not fixed. All versions which I tested (2.6.35 to 3.2) have this problem.

More info: This problem seems to be on new EliteBooks 8x60 which have Radeon graphics card. Model with integrated Intel have no problem. Writing any value to "/sys/class/backlight/acpi_video0/brightness" has no effect. And some people said that this problem is only with open source radeon kms driver - when they used fglrx there was no brightness problem. See http://www.linlap.com/wiki/hp+elitebook+8460p

See also thread on linux-acpi where I reported this problem: http://www.spinics.net/lists/linux-acpi/msg33107.html
Comment 9 Pali Rohár 2012-02-05 12:35:50 UTC
*** Bug 41112 has been marked as a duplicate of this bug. ***
Comment 10 Pali Rohár 2012-02-05 12:37:04 UTC
More info is here: http://www.mail-archive.com/platform-driver-x86@vger.kernel.org/msg02862.html
Brightness control maybe need to be implemented in radeon driver...
Comment 11 Pali Rohár 2012-05-17 09:37:08 UTC
Hi any news about this problem? What other info do you need?
Comment 12 Vasilis Lourdas 2012-05-24 19:34:48 UTC
Just upgraded my system from kernel-3.3.5 (gentoo-sources) to 3.4.0. The problem persisted in both 3.3 and now in 3.4 series kernels.

What more info can we provide in order to help debug this issue?
Comment 13 Robert Brunnthaler 2012-06-09 06:56:50 UTC
I also would like to offer my help. That I have to reboot my laptop every time I want to change the brightness of the display isn't a really "workaround".
kr
rb
Comment 14 richlv 2012-07-01 10:15:02 UTC
this issue is in NEEDINFO state - what additional information is needed ?
maybe i can provide it
Comment 15 Pali Rohár 2012-07-28 13:50:54 UTC
What information do you need? Is not info in this thread enought?
http://www.mail-archive.com/platform-driver-x86@vger.kernel.org/msg02862.html
Comment 16 Pali Rohár 2012-07-28 13:58:03 UTC
Also, maybe this new code for radeon driver is relevant:
http://lists.freedesktop.org/archives/dri-devel/2012-July/025517.html
Comment 17 Pali Rohár 2012-07-28 15:13:24 UTC
Ok, I tested patches from this post:
http://lists.freedesktop.org/archives/dri-devel/2012-July/025535.html

And it really can change brighntes on HP EliteBook 8460p (with Radeon 6470M) via file:
/sys/class/backlight/radeon_bl/brightness
Comment 18 Vasilis Lourdas 2012-07-28 19:01:12 UTC
(In reply to comment #17)
> Ok, I tested patches from this post:
> http://lists.freedesktop.org/archives/dri-devel/2012-July/025535.html
> 
> And it really can change brighntes on HP EliteBook 8460p (with Radeon 6470M)
> via file:
> /sys/class/backlight/radeon_bl/brightness

Ok, we seem to have some progress here. Against which kernel version did you try the patch?

Not being able to reduce the brightness is an issue. I'm sitting at my balcony with 30°C and the full brightness is really annoying. Not to mention it attracts many mosquitoes. :-)
Comment 19 Zhang Rui 2012-11-28 06:55:37 UTC
to me, the problem seems to be that
1) ACPI backlight control does not work
2) we're missing the backlight control from Radeon DRM driver.
Comment 20 Vasilis Lourdas 2012-12-08 21:42:02 UTC
Is there any progress regarding this issue? I'm already on kernel 3.6.8 and this is a big issue. Not to mention that I replaced the faulty screen (it did not light up at all) a couple of days ago and I'm wondering if my issue had to do with the 100% full brightness setting at all times.
Comment 21 Vasilis Lourdas 2012-12-12 19:01:43 UTC
Great news. I just booted with kernel 3.7.0 (Gentoo box) in my laptop and the brightness control keys work fine! The screen brightness is reduced/increased as needed.

So, I guess from kernel 3.7.0 this bug can be considered closed.
Comment 22 Pali Rohár 2012-12-12 19:10:50 UTC
Yes, above patches are in 3.7, so bug is fixed.
Comment 23 Zhang Rui 2012-12-13 00:27:46 UTC
commit 9e05b2f49eb9484e857e9b6c70dea3bbbe564290
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Wed Jul 18 13:28:52 2012 -0400

    drm/radeon: add new AMD ACPI header and update relevant code (v2)
    
    Add a new header that defines the AMD ACPI interface used
    for laptops, PowerXpress, and chipset specific functionality
    and update the current code to use it.
    
    Todo:
    - properly verify the ACPI interfaces
    - hook up and handle ACPI notifications
    - make PX code more robust
    - implement PCIe Gen and width switching using ACPI
    
    v2: fix typo in header
    
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>