Bug 39842

Summary:	savagefb.h CARD SERIES definition typo
Product:	Drivers	Reporter:	jpsinthemix
Component:	Video(Other)	Assignee:	drivers_video-other
Status:	CLOSED CODE_FIX
Severity:	normal	CC:	florian, maciej.rutecki, rjw
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	3.0.0	Subsystem:
Regression:	Yes	Bisected commit-id:
Bug Depends on:
Bug Blocks:	36912

Description jpsinthemix 2011-07-23 10:20:40 UTC

I have an old T22 Thinkpad with integrated Savage/IX-MV video. As of linux-3.0, the video is non-functional; the PC either hard hangs immediately or has totally garbled video, and then hard hangs, as soon as I attempt to edit a file or cat a file with more than a screen-full of text. The foregoing details are actually not important any more as in looking at the code changes I discovered a typo in linux-3.0.0/drivers/video/savage/savagefb.h and have applied the following patch to fix the issue:

--- linux-3.0.0.old/drivers/video/savage/savagefb.h     2011-07-21 22:17:23.000000000 -0400
+++ linux-3.0.0.new/drivers/video/savage/savagefb.h     2011-07-23 05:13:33.801215293 -0400
@@ -55,7 +55,7 @@

 #define S3_SAVAGE3D_SERIES(chip)  ((chip>=S3_SAVAGE3D) && (chip<=S3_SAVAGE_MX))

-#define S3_SAVAGE4_SERIES(chip)   ((chip>=S3_SAVAGE4) || (chip<=S3_PROSAVAGEDDR))
+#define S3_SAVAGE4_SERIES(chip)   ((chip>=S3_SAVAGE4) && (chip<=S3_PROSAVAGEDDR))

 #define S3_SAVAGE_MOBILE_SERIES(chip)  ((chip==S3_SAVAGE_MX) || (chip==S3_SUPERSAVAGE))


P.S. Many, many thanks for lifting the 800x600 resolution limit! I've been using a patch/hack to bump the limit to 1024x768 for an very long time...
John

Comment 1 Andrew Morton 2011-07-28 23:28:26 UTC

(switched to email.  Please respond via emailed reply-to-all, not via the
bugzilla web interface).

On Sat, 23 Jul 2011 10:20:41 GMT
bugzilla-daemon@bugzilla.kernel.org wrote:

> https://bugzilla.kernel.org/show_bug.cgi?id=39842
> 
>            Summary: savagefb.h CARD SERIES definition typo
>            Product: Drivers
>            Version: 2.5
>     Kernel Version: 3.0.0
>           Platform: All
>         OS/Version: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: Video(Other)
>         AssignedTo: drivers_video-other@kernel-bugs.osdl.org
>         ReportedBy: jpsinthemix@verizon.net
>         Regression: Yes
> 
> 
> I have an old T22 Thinkpad with integrated Savage/IX-MV video. As of
> linux-3.0,
> the video is non-functional; the PC either hard hangs immediately or has
> totally garbled video, and then hard hangs, as soon as I attempt to edit a
> file
> or cat a file with more than a screen-full of text. The foregoing details are
> actually not important any more as in looking at the code changes I
> discovered
> a typo in linux-3.0.0/drivers/video/savage/savagefb.h and have applied the
> following patch to fix the issue:
> 
> --- linux-3.0.0.old/drivers/video/savage/savagefb.h     2011-07-21
> 22:17:23.000000000 -0400
> +++ linux-3.0.0.new/drivers/video/savage/savagefb.h     2011-07-23
> 05:13:33.801215293 -0400
> @@ -55,7 +55,7 @@
> 
>  #define S3_SAVAGE3D_SERIES(chip)  ((chip>=S3_SAVAGE3D) &&
> (chip<=S3_SAVAGE_MX))
> 
> -#define S3_SAVAGE4_SERIES(chip)   ((chip>=S3_SAVAGE4) ||
> (chip<=S3_PROSAVAGEDDR))
> +#define S3_SAVAGE4_SERIES(chip)   ((chip>=S3_SAVAGE4) &&
> (chip<=S3_PROSAVAGEDDR))
> 
>  #define S3_SAVAGE_MOBILE_SERIES(chip)  ((chip==S3_SAVAGE_MX) ||
> (chip==S3_SUPERSAVAGE))
> 
> 
> P.S. Many, many thanks for lifting the 800x600 resolution limit! I've been
> using a patch/hack to bump the limit to 1024x768 for an very long time...
> John

Please resend that fix as a formal signed-off-patch as a reply-to-all
to this email?  Documentation/SubmittingPatches has some tips.

Thanks.

Comment 2 jpsinthemix 2011-07-29 13:16:52 UTC

Replying to all.. I have also attached the one-line patch.
thanks,
John

On 07/28/2011 07:27 PM, Andrew Morton wrote:
> (switched to email.  Please respond via emailed reply-to-all, not via the
> bugzilla web interface).
>
> On Sat, 23 Jul 2011 10:20:41 GMT
> bugzilla-daemon@bugzilla.kernel.org wrote:
>
>> https://bugzilla.kernel.org/show_bug.cgi?id=39842
>>
>>             Summary: savagefb.h CARD SERIES definition typo
>>             Product: Drivers
>>             Version: 2.5
>>      Kernel Version: 3.0.0
>>            Platform: All
>>          OS/Version: Linux
>>                Tree: Mainline
>>              Status: NEW
>>            Severity: normal
>>            Priority: P1
>>           Component: Video(Other)
>>          AssignedTo: drivers_video-other@kernel-bugs.osdl.org
>>          ReportedBy: jpsinthemix@verizon.net
>>          Regression: Yes
>>
>>
>> I have an old T22 Thinkpad with integrated Savage/IX-MV video. As of
>> linux-3.0,
>> the video is non-functional; the PC either hard hangs immediately or has
>> totally garbled video, and then hard hangs, as soon as I attempt to edit a
>> file
>> or cat a file with more than a screen-full of text. The foregoing details
>> are
>> actually not important any more as in looking at the code changes I
>> discovered
>> a typo in linux-3.0.0/drivers/video/savage/savagefb.h and have applied the
>> following patch to fix the issue:
>>
>> --- linux-3.0.0.old/drivers/video/savage/savagefb.h     2011-07-21
>> 22:17:23.000000000 -0400
>> +++ linux-3.0.0.new/drivers/video/savage/savagefb.h     2011-07-23
>> 05:13:33.801215293 -0400
>> @@ -55,7 +55,7 @@
>>
>>   #define S3_SAVAGE3D_SERIES(chip)  ((chip>=S3_SAVAGE3D)&&
>> (chip<=S3_SAVAGE_MX))
>>
>> -#define S3_SAVAGE4_SERIES(chip)   ((chip>=S3_SAVAGE4) ||
>> (chip<=S3_PROSAVAGEDDR))
>> +#define S3_SAVAGE4_SERIES(chip)   ((chip>=S3_SAVAGE4)&&
>> (chip<=S3_PROSAVAGEDDR))
>>
>>   #define S3_SAVAGE_MOBILE_SERIES(chip)  ((chip==S3_SAVAGE_MX) ||
>> (chip==S3_SUPERSAVAGE))
>>
>>
>> P.S. Many, many thanks for lifting the 800x600 resolution limit! I've been
>> using a patch/hack to bump the limit to 1024x768 for an very long time...
>> John
> Please resend that fix as a formal signed-off-patch as a reply-to-all
> to this email?  Documentation/SubmittingPatches has some tips.
>
> Thanks.
>
>

Comment 3 Florian Mickler 2011-08-09 08:07:49 UTC

merged in v3.1-rc1:
commit 4b00e4b3940eabb38adeec0823751820fe2d6fda
Author: John Stanley <jpsinthemix@verizon.net>
Date:   Wed Aug 3 20:41:00 2011 -0400

    savagedb: Fix typo causing regression in savage4 series video chip detection