Bug 3869

Summary:	(net sk98lin) driver fails on all kernels post 2.6.7
Product:	Drivers	Reporter:	RaXeT (maxer1)
Component:	Network	Assignee:	Stephen Hemminger (stephen)
Status:	CLOSED CODE_FIX
Severity:	normal	CC:	stephen
Priority:	P2
Hardware:	i386
OS:	Linux
Kernel Version:	2.6.10 rc3	Subsystem:
Regression:	---	Bisected commit-id:

Description RaXeT 2004-12-05 17:42:44 UTC

Distribution: Fedora Core 3
Hardware Environment: Intel D915 GEV mobo, Marvell Gigabit lan etc
Software Environment: Fedora Core 3
Problem Description: sk98lin.ko

Steps to reproduce: Just boot any distro - driver is never detected

I went to the SysKonnect site and found a patch for the driver dated October 20,
2004, patched the driver in 2.6.9 kernel and it now works. Could the maintainer
please explain why nothing has been accomplished since 2.6.7 kernel on this?

Comment 1 RaXeT 2004-12-11 14:14:03 UTC

2.6.10-rc3 fixed

Comment 2 RaXeT 2004-12-11 20:51:45 UTC

Here is the output when attempting to patch kernel 2.6.10-rc3 with the driver
patch from syskonnect.com:

cat /home/raxet/DriverInstall/sk98lin_v7.09_2.6.9_patch | patch -p1
patching file drivers/net/sk98lin/h/lm80.h
patching file drivers/net/sk98lin/h/skaddr.h
patching file drivers/net/sk98lin/h/skcsum.h
patching file drivers/net/sk98lin/h/skdebug.h
patching file drivers/net/sk98lin/h/skdrv1st.h
patching file drivers/net/sk98lin/h/skdrv2nd.h
Hunk #5 FAILED at 212.
1 out of 6 hunks FAILED -- saving rejects to file
drivers/net/sk98lin/h/skdrv2nd.h.rej
patching file drivers/net/sk98lin/h/skerror.h
patching file drivers/net/sk98lin/h/skgedrv.h
patching file drivers/net/sk98lin/h/skgehw.h
patching file drivers/net/sk98lin/h/skgehwt.h
patching file drivers/net/sk98lin/h/skgei2c.h
patching file drivers/net/sk98lin/h/skgeinit.h
patching file drivers/net/sk98lin/h/skgepnm2.h
patching file drivers/net/sk98lin/h/skgepnmi.h
patching file drivers/net/sk98lin/h/skgesirq.h
patching file drivers/net/sk98lin/h/skgetwsi.h
patching file drivers/net/sk98lin/h/ski2c.h
patching file drivers/net/sk98lin/h/skqueue.h
patching file drivers/net/sk98lin/h/skrlmt.h
patching file drivers/net/sk98lin/h/sktimer.h
patching file drivers/net/sk98lin/h/sktwsi.h
patching file drivers/net/sk98lin/h/sktypes.h
patching file drivers/net/sk98lin/h/skversion.h
patching file drivers/net/sk98lin/h/skvpd.h
patching file drivers/net/sk98lin/h/sky2le.h
patching file drivers/net/sk98lin/h/xmac_ii.h
patching file drivers/net/sk98lin/Makefile
patching file drivers/net/sk98lin/skaddr.c
patching file drivers/net/sk98lin/skcsum.c
patching file drivers/net/sk98lin/skdim.c
patching file drivers/net/sk98lin/skethtool.c
patching file drivers/net/sk98lin/skge.c
Hunk #2 FAILED at 36.
1 out of 98 hunks FAILED -- saving rejects to file drivers/net/sk98lin/skge.c.rej
patching file drivers/net/sk98lin/skgehwt.c
patching file drivers/net/sk98lin/skgeinit.c
patching file drivers/net/sk98lin/skgemib.c
patching file drivers/net/sk98lin/skgepnmi.c
patching file drivers/net/sk98lin/skgesirq.c
patching file drivers/net/sk98lin/ski2c.c
patching file drivers/net/sk98lin/sklm80.c
patching file drivers/net/sk98lin/skproc.c
patching file drivers/net/sk98lin/skqueue.c
patching file drivers/net/sk98lin/skrlmt.c
patching file drivers/net/sk98lin/sktimer.c
patching file drivers/net/sk98lin/sktwsi.c
patching file drivers/net/sk98lin/skvpd.c
patching file drivers/net/sk98lin/skxmac2.c
patching file drivers/net/sk98lin/sky2.c
patching file drivers/net/sk98lin/sky2le.c
patching file Documentation/networking/sk98lin.txt
patching file drivers/net/Kconfig
Hunk #1 succeeded at 1979 (offset -82 lines).
Hunk #3 succeeded at 2003 (offset -82 lines).
Hunk #4 succeeded at 2181 with fuzz 2.

Comment 3 RaXeT 2004-12-11 20:54:27 UTC

Affecting 2.6.10 rc3

Comment 4 Dominik Mierzejewski 2005-03-15 11:36:49 UTC

http://www.syskonnect.com/syskonnect/support/driver/zip/linux/ contains the
latest versions available, including 8.14 beta, which I've been running for two
days now with no adverse effects. I'd be very happy to see the sk98lin driver
updated in the official kernel sources.

Comment 5 Dominik Mierzejewski 2005-03-15 11:43:43 UTC

Forgot to add: I'm running Fedora Core 3 x86_64, kernel
2.6.10-1.770_FC3.1.x86_64. The ".1" comes from the updated sk98lin driver I
added to the SRPM using "make kernel patch" option of syskonnect's install
script and some minor specfile tweaks. I will post a new bug in Fedora's
bugzilla about this.

My card is:
# lspci
...
05:00.0 Ethernet controller: Marvell Technology Group Ltd. Marvell Yukon 88E8053
Gigabit Ethernet 10/100/1000Base-T Adapter (rev 15)
...
# cat /proc/net/sk98lin/eth0

Detailed statistic for device eth0
=======================================

Board statistics

Card name                      Yukon Gigabit Ethernet 10/100/1000Base-T Adapter
Vendor/Device ID               11ab/4362
Card type (Bit)                64
Active Port                    A
Preferred Port                 A
Interrupt Moderation           disabled
Bus type                       PCI-Express
Bus width (Lanes)              1
Driver version                 8.14.2.2 (beta) (02)
Driver release date            Feb-07-2005
Hardware revision              v1.5
...

The motherboard is ASUS A8V-E Deluxe, with VIA K8T890 chipset.

Comment 6 Mark Allyn 2005-08-15 16:46:02 UTC

I have noticed the same problem with the 2.6.12 kernel as of August 15,
2005. 

I was able to resolve the problem by replacing the sk98lin module with
that from syskonnect.com.

Can we consider updating the sk98lin driver to that which is hosted by
Syskonnect? I do notice that the source code does contain the GPL License.

Comment 7 Stephen Hemminger 2005-08-15 17:12:23 UTC

The new sk98lin driver from SysKonnect has been submitted for review
and not accepted in it's current form because of style incompatiablities,
not being broken up into small pieces, and not incorporating bugfixes
and other changes from the main linux kernel tree.

I looked at it and the mess motivated me to create the skge driver
and work on a sky2 driver.

Comment 8 Stephen Hemminger 2006-01-18 11:26:39 UTC

Sky2 driver is now in 2.6.16-rc1