Bug 36902

Summary: Kernel compilation fails at module apm.ko
Product: Power Management Reporter: David Hill (hilld)
Component: APMAssignee: Stephen Rothwell (apmbugs)
Status: CLOSED CODE_FIX    
Severity: normal CC: hilld, randy.dunlap, vitalivanov
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 3.0.0-rc1,rc2 Subsystem:
Regression: Yes Bisected commit-id:
Attachments: Kernel .config file
Dynamic select of APM_CPU_IDLE feature for enabling APM.

Description David Hill 2011-06-07 15:34:38 UTC 
Kernel compilation fails at module apm.ko with the following message:

ERROR: "pm_idle" [arch/x86/kernel/apm.ko] undefined!
ERROR: "default_idle" [arch/x86/kernel/apm.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Comment 1 David Hill 2011-06-07 15:36:33 UTC 
Created attachment 61092 [details]
Kernel .config file
Comment 2 Vitaliy Ivanov 2011-06-10 16:10:14 UTC 
David,

With the config that you attached it should not be reproducible.

When APM is build then we need "pm_idle" and "default_idle" to be available.
They are currently under APM_CPU_IDLE option. So, making is available in your config automatically solves the problem.

I'm sending patch to dynamic select APM_CPU_IDLE on APM selection.

Can you please double check it?
Comment 3 Vitaliy Ivanov 2011-06-13 13:05:54 UTC 
Created attachment 61822 [details]
Dynamic select of APM_CPU_IDLE feature for enabling APM.

I saw email about removing APM completely but as of now we can add the following to close build issue.
---
Dynamic select of APM_CPU_IDLE feature for enabling APM.

Signed-off-by: Vitaliy Ivanov <vitalivanov@gmail.com>

>From f00634bec035f1526266340bf75aa4e2620c8284 Mon Sep 17 00:00:00 2001
From: Vitaliy Ivanov <vitalivanov@gmail.com>
Date: Fri, 10 Jun 2011 19:06:37 +0300
Subject: [PATCH] Dynamic select of APM_CPU_IDLE on APM enabling.
Comment 4 Randy Dunlap 2011-06-14 21:22:49 UTC 
Fixed by git commit 60b8b1de0dd2bf246f0e074d287bb3f0bc42a755.