Bug 36082

Summary:	samsung-laptop: N150 DMI mismatch
Product:	Drivers	Reporter:	Daniel Eklöf (daniel)
Component:	Platform_x86	Assignee:	drivers_platform_x86 (drivers_platform_x86)
Status:	CLOSED CODE_FIX
Severity:	normal	CC:	florian, greg, thcourbon
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	2.6.39	Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	Hack to allow driver to load without force=1 DMI output dmidecode output for a N210 samsung netbook

Description Daniel Eklöf 2011-05-28 11:10:20 UTC

The samsung-laptop driver fails to load on my laptop (N150), due to a DMI mismatch: the driver expexts N230 to be in the identifier (and product/board name), whereas my laptop only includes N150/N210/N220.

Full DMI output is attached.

Comment 1 Daniel Eklöf 2011-05-28 11:13:13 UTC

Created attachment 59742 [details]
Hack to allow driver to load without force=1

This is just a quick patch I put together to verify there weren't any other issues with the driver on my laptop (there weren't).

It simply removes N230 from the DMI identifier, allowing the driver to be loaded without force=1.

Comment 2 Daniel Eklöf 2011-05-28 11:19:56 UTC

Created attachment 59752 [details]
DMI output

Comment 3 Thomas Courbon 2011-07-17 14:31:52 UTC

I have a Samsung netbook N210 and the samsung-laptop driver failed to load:
[root@localhost ~]# modprobe -v samsung-laptop
insmod /lib/modules/3.0.0-desktop-0.rc7.2.1.mga2/kernel/drivers/platform/x86/samsung-laptop.ko.gz 
FATAL: Error inserting samsung_laptop (/lib/modules/3.0.0-desktop-0.rc7.2.1.mga2/kernel/drivers/platform/x86/samsung-laptop.ko.gz): No such device

The symptoms are very similar to those described by Daniel Eklöf and I think we encoutered the same issue.

Dmidecode output attached.

(On a side note, even if I load the driver with force=1 the brightness keys don't work but I can set the brightness by writing "1" or "8" several time to /sys/class/backlight/samsung/brightness. I'm still trying to figure out where this issue is from.)

Comment 4 Thomas Courbon 2011-07-17 14:32:42 UTC

Created attachment 65872 [details]
dmidecode output for a N210 samsung netbook

Comment 5 Florian Mickler 2011-08-08 14:11:09 UTC

A patch referencing this bug report has been merged in Linux v3.1-rc1:

commit 78a7539b881eb557494a7c810625c0307b27296c
Author: Thomas Courbon <thcourbon@gmail.com>
Date:   Wed Jul 20 22:57:44 2011 +0200

    Platform: fix samsung-laptop DMI identification for N150/N210/220/N230

Comment 6 Daniel Eklöf 2011-08-08 16:40:06 UTC

Confirmed to work on my N150.