Bug 31522

Created attachment 51382 [details]
lspci + dmesg (drm.debug=0xe)  [gm45 chipset]

broken here with S2R

full dmesg is here:
http://fpaste.org/HYVU/

(In reply to comment #2)
> broken here with S2R

Different bug. Try revert a7a75c8f70d6f6a2f16c9f627f938bbee2d32718

On 03/21/2011 12:40 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=31522
>
>
> Chris Wilson<chris@chris-wilson.co.uk>  changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                   CC|                            |chris@chris-wilson.co.uk
>
>
>
>
> --- Comment #3 from Chris Wilson<chris@chris-wilson.co.uk>   2011-03-21
> 07:40:32 ---
> (In reply to comment #2)
>> broken here with S2R
>
> Different bug. Try revert a7a75c8f70d6f6a2f16c9f627f938bbee2d32718
>

cool thanks... will try the revert and see!!

Justin P. Mattock

commit ba3820ade317ee36e496b9b40d2ec3987dd4aef0
Author: Takashi Iwai <tiwai@suse.de>
Date:   Thu Mar 10 14:02:12 2011 +0100

    drm/i915: Revive combination mode for backlight control
    
    This reverts commit 951f3512dba5bd44cda3e5ee22b4b522e4bb09fb
    
        drm/i915: Do not handle backlight combination mode specially
    
    since this commit introduced other regressions due to untouched LBPC
    register, e.g. the backlight dimmed after resume.

On Tue, 2011-04-05 at 12:47 +0000, bugzilla-daemon@bugzilla.kernel.org
wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=31522
> 
> 
> Chris Wilson <chris@chris-wilson.co.uk> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|NEW                         |RESOLVED
>          Resolution|                            |CODE_FIX
> 
> 
> 
> 
> --- Comment #5 from Chris Wilson <chris@chris-wilson.co.uk>  2011-04-05
> 12:47:54 ---
> commit ba3820ade317ee36e496b9b40d2ec3987dd4aef0
> Author: Takashi Iwai <tiwai@suse.de>
> Date:   Thu Mar 10 14:02:12 2011 +0100
> 
>     drm/i915: Revive combination mode for backlight control
> 
>     This reverts commit 951f3512dba5bd44cda3e5ee22b4b522e4bb09fb
> 
>         drm/i915: Do not handle backlight combination mode specially
> 
>     since this commit introduced other regressions due to untouched LBPC
>     register, e.g. the backlight dimmed after resume.
> 
not sure what the bug report says..cant seem to connect to it..will try
later as well as pull the latest on that machine to see if this is
fixed.

Justin P. Mattock

On Tue, Apr 5, 2011 at 8:33 AM, Justin P. Mattock
<justinmattock@gmail.com> wrote:
> On Tue, 2011-04-05 at 12:47 +0000, bugzilla-daemon@bugzilla.kernel.org
> wrote:
>> https://bugzilla.kernel.org/show_bug.cgi?id=31522
>>
>>
>> Chris Wilson <chris@chris-wilson.co.uk> changed:
>>
>>            What    |Removed                     |Added
>> ----------------------------------------------------------------------------
>>              Status|NEW                         |RESOLVED
>>          Resolution|                            |CODE_FIX
>>
>>
>>
>>
>> --- Comment #5 from Chris Wilson <chris@chris-wilson.co.uk>  2011-04-05
>> 12:47:54 ---
>> commit ba3820ade317ee36e496b9b40d2ec3987dd4aef0
>> Author: Takashi Iwai <tiwai@suse.de>
>> Date:   Thu Mar 10 14:02:12 2011 +0100
>>
>>     drm/i915: Revive combination mode for backlight control
>>
>>     This reverts commit 951f3512dba5bd44cda3e5ee22b4b522e4bb09fb
>>
>>         drm/i915: Do not handle backlight combination mode specially
>>
>>     since this commit introduced other regressions due to untouched LBPC
>>     register, e.g. the backlight dimmed after resume.
>>
> not sure what the bug report says..cant seem to connect to it..will try
> later as well as pull the latest on that machine to see if this is
> fixed.
>
> Justin P. Mattock
>
>

o.k. finally pulled on that machine, and tested it out... everything works..
there is some messages in dmesg, but I dont think they are harmless..
(I can attache that as soon as I get back on that machine)

This is not fixed. The screen still remains black here, even under 2.6.38.4, though under ideal conditions I can see that only the backlight is off. The problem was introduced with commit ba3820ade317ee36e496b9b40d2ec3987dd4aef0. It turned out that on this machine INTEL_INFO(dev)->gen equals 4, and is_backlight_combination_mode() returns 0x40000000.

Please tell me what more info you need.

In 'intel_panel_get_backlight()' this happens:


  val = I915_READ(BLC_PWM_CTL) & BACKLIGHT_DUTY_CYCLE_MASK; // val = 0x0b4a
  if (IS_PINEVIEW(dev))                                     // false
          val >>= 1;

  if (is_backlight_combination_mode(dev)){
          u8 lbpc;

          val &= ~1;                                        // val = 0x0b4a
          pci_read_config_byte(dev->pdev, PCI_LBPC, &lbpc); // lbpc = 0
          val *= lbpc;                                      // val = 0
  }

References: http://marc.info/?l=linux-kernel&m=130409270332174&w=2

Patch: https://patchwork.kernel.org/patch/743162/

Is this patch going to be merged?

The patch was based on an earlier bug description which turned out to be wrong. It doesn't fix the problem, which is still in 3.0-rc2+ (3c25fa740e20).

The real problem was identified as backwards LBPC values: 0x00 = bright, getting darker with growing values, 0xff = dark. See https://lkml.org/lkml/2011/5/17/157

In case someone wants to check their LBPC values:
  % lspci -xxx -s 00:02.0|awk '/^f0:/ {print $6}'   # get
  % setpci -s 00:02.0 F4.B=ff                       # set

Ignore-Patch: https://patchwork.kernel.org/patch/743162/

Yet another Acer with inverted backlight. Please try the drm-intel-testing branch from

http://cgit.freedesktop.org/~danvet/drm-intel/

if that does not help, please attach the full output of lspci -vmmn so that we can add another quirk entry.

Assuming this is fixed now until we hear otherwise.

No, it's not fixed, not until 3.3.1.

(Haven't tested later kernels yet, because the b43 driver hard-freezes the machine now, and I haven't had time to get into that far more serious problem.)

Please re-open, and don't close again until I say it's fixed.

You can't re-open?

I definitely sympathize with the b43 issue; I hate it when I upgrade the kernel to test something and some other driver totally breaks things.

once I get to this machine and update everything I can give you a better answer to this.. as for i915 itself I have another machine that is getting choppy playback with flash(watching hulu) with using the latest linux-next(next-rc1 is fine as well as linus's current).

Note to self: We still need the test result on drm-intel-testing. If that alone does not work, please try with i915.i915_panel_invert_brightness=1 added to the kernel command line. If it works with the added parameter, please attach lspci -vmmn

I'm sorry for the long delay.

The drm-intel tree as of today (25fcc53b96dd4801907d9b1cc4b76258ab0f3d65) doesn't fix the problem. The i915.i915_panel_invert_brightness=1 command, however, does. Unfortunately, it gets the horizontal screen resolution wrong on the console and in X, and it leads to wrong color artifacts. Without the "invert" line everything is fine (apart from the original problem: the black screen).

Thanks for your reply. Future responses will be quicker. A lot. (The b43 bug seems to be fixed.  :-)

Created attachment 73293 [details]
lspci

Hm, can you double-check that the i915 module is still loaded with the additional commandline option? If it's mistyped, the kernel will refuse to load the kms driver and the display will be driven by the vbios/vga code.

Otherwise this result is expected, the invert brightness code is actually bogus. New patches are in the works, but atm I'm swamped. So don't hold your breath.

Argh, you are right -- I missed that. dmesg says:

  i915: Unknown parameter `i915_panel_invert_brightness'

But that *was* the drm-intel-next kernel branch. Hmm ...

Ok, I've created a patch-series to fix up our backlight confusion on gen4+ Please test the backlight-confusion branch from my git repo at

http://cgit.freedesktop.org/~danvet/drm

Same broken behaviour, I'm afraid. Screen stays black, "brightness down" key turns it on (and darker).

Ok, I've updated my backlight-confusion branch with new patches for gen4. Please retest, thanks.

Works!  :-)

Oh, wait. That was too quick: Yes, the screen is now bright at startup, but adjusting brightness does no longer work, which is worse. But still, looks like you are almost there.

Hm, back to square one actually :( Btw, what happens when you suspend/resume?

(In reply to comment #26)
> Ok, I've updated my backlight-confusion branch with new patches for gen4.
> Please retest, thanks.

Updated patches and discussion at [1], also available in the "backlight" branch of [2]. Please test.

[1] http://thread.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/13642
[2] git://gitorious.org/jani/drm.git

Please try i915.invert_brightness=1 module parameter with kernel version v3.5 or later, see if that fixes the brightness issue, and report 'lspci -vmmnn' if it does.

Reporter seems to be awol, closing this. Please reopen once you have the things tested as request in comment #31, thanks.

yeah this was fixed for me with the dell inspiron 600 unfortunately
that machine crapped out on me to the point I had to retire it.
so I agree with closing this one.  unless anybody else has objections

On Tue, Nov 13, 2012 at 3:27 AM,  <bugzilla-daemon@bugzilla.kernel.org> wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=31522
>
>
> Daniel Vetter <daniel@ffwll.ch> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|NEEDINFO                    |RESOLVED
>          Resolution|                            |INSUFFICIENT_DATA
>
>
>
>
> --- Comment #32 from Daniel Vetter <daniel@ffwll.ch>  2012-11-13 11:27:53 ---
> Reporter seems to be awol, closing this. Please reopen once you have the
> things
> tested as request in comment #31, thanks.
>
> --
> Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.

My machine doesn't boot from disk at the moment -- after an OpenSUSE update a while ago, and because the disk is encrypted, restoration is a bit more work than I had time for when I came home late from work. But I've planned to make it work again within a week or two and then I'll test (and reopen if necessary). I'm sorry for the delay.

Created attachment 86511 [details]
Output of "lspci -vmmnn" 

Required output of 'lspci -vmmnn'. Using Ubuntu 12.10, kernel 3.5.0-18-generic, on eMachines e725.

The parameter "i915.invert_brightness=1" did solve the issue, although recently I still experienced the black screen again (when closing the laptop, while another monitor was connected. Unable to reproduce the problem, though).

Please comment if additional info is necessary.

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/765438/comments/58
"I FOUND bug
needs confirmation
i just tested witch works and since when doest until 4 in row from http://kernel.ubuntu.com/~kernel-ppa/mainline/
Confirm by installing kernels

No this bug using:
[DIR] v2.6.36.4-natty/ 18-Feb-2011 11:34 - http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.36.4-natty/
This bug starts in every next kernel since:
[DIR] v2.6.37-natty/ 05-Jan-2011 11:23 - http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.37-natty/

take files starting with linux-image-*** ending with *** your architecture i386.deb or amd64.deb
then install them and restart in each kernel.
For my Emachines E525 this is how i wrote.
"

Created attachment 91631 [details]
drm/i915: add quirk to invert brightness on eMachines e725

(In reply to comment #35)
> Created an attachment (id=86511) [details]
> Output of "lspci -vmmnn" 
> 
> Required output of 'lspci -vmmnn'. Using Ubuntu 12.10, kernel
> 3.5.0-18-generic,
> on eMachines e725.

Martins, please try the attached patch. Do *not* use i915.invert_brigthness=1 module parameter when you try it.

The patch should fix the issue on the particular machine reported in comment #35. Anyone having a backlight issue that i915.invert_brigthness=1 fixes, please report 'lspci -vmmnn' along with the vendor and model of the machine.

Patch merged for drm-intel-next:

commit 01e3a8feb40e54b962a20fa7eb595c5efef5e109                                                                                      
Author: Jani Nikula <jani.nikula@intel.com>                                                                                          
Date:   Tue Jan 22 12:50:35 2013 +0200                                                                                               
                                                                                                                                     
    drm/i915: add quirk to invert brightness on eMachines e725

Created attachment 92451 [details]
Output of lspci -vmmnn on eMachines 525

Hello,

Parameter i915.invert_brigthness=1 helps with a build-in backlight on eMachines e525 notebook with Intel video card (GM45), but with this parameter the resolution is fixed to 1024x768 on a widescreen monitor and cannot be changed. I also attached result of lspci -vmmnn. I look now with hope into the future :) Thanks for great work.

Greetings,
Mateusz Lach

Mateusz -

(In reply to comment #40)
> Parameter i915.invert_brigthness=1 helps with a build-in backlight on
> eMachines
> e525 notebook with Intel video card (GM45), but with this parameter the
> resolution is fixed to 1024x768 on a widescreen monitor and cannot be
> changed.

Well, that's not right. I see that you're not one of the earlier reporters of the bug, and we just can't go about adding quirks with insufficient information.

First, you have a typo above for the module parameter. Did you make the same typo in your config? That would explain the symptoms. But does it fix the issue anymore? And what exactly is *your* issue in the first place?

I think we'd prefer a new bug for each quirk no matter what, just for tracking purposes (for example, if something goes wrong with the fix to your problem, we don't want to reopen and revisit this already fixed bug). Please file a new bug with your symptoms, whether i915.invert_brightness=1 (with the correct spelling) helps them, and your 'lspci -vmmnn'. The fix can be swift once we confirm the facts. Thanks.

Hello,

Jani, I made this typo only here in the comment. My issue in the first place is black screen at boot time and later after the X are loaded (all the time exactly). Parameter i915.invert_brightness=1 helps me with this issue the same way as "nomodeset". So the backlight works perfect, but I have problem with resolution of screen. 

Summary:
1. For me the reported bug is fixed with i915.invert_brightness=1,
2. There are some problems, but I will report them as a new bug, as you suggested.

Thank you very much :)