Bug 30752

Summary: NFS sillyrenamed files are not being deleted after close
Product: File System Reporter: Jeff Layton (jlayton)
Component: NFSAssignee: Trond Myklebust (trondmy)
Status: CLOSED CODE_FIX    
Severity: normal CC: florian, maciej.rutecki, rjw
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 2.6.38-rc7 Tree: Mainline
Regression: Yes
Bug Depends on:    
Bug Blocks: 27352    

Description Jeff Layton 2011-03-08 13:21:36 UTC
I'm opening this bug to ensure that 2.6.38 doesn't ship with sillyrenames still broken. If someone has already done so, please feel free to close this one as a duplicate.

This is a regression introduced by patch 949854d0.  Trond has a proposed patch to fix it here, but there are other possible approaches:

http://git.linux-nfs.org/?p=trondmy/nfs-2.6.git;a=commit;h=674d01f97d0094e8c383f7dbdf0782a304f6348b
Comment 1 Rafael J. Wysocki 2011-03-10 00:02:17 UTC
Patch : http://git.linux-nfs.org/?p=trondmy/nfs-2.6.git;a=commit;h=674d01f97d0094e8c383f7dbdf0782a304f6348b
Handled-By : trond.myklebust@fys.uio.no

First-Bad-Commit : 949854d02455080d20cd3e1db28a3a18daf7599d

commit 949854d02455080d20cd3e1db28a3a18daf7599d
Author: Nick Piggin <npiggin@kernel.dk>
Date:   Fri Jan 7 17:49:37 2011 +1100

    fs: Use rename lock and RCU for multi-step operations
Comment 2 Trond Myklebust 2011-03-15 23:48:52 UTC
Should be fixed by commit c83ce989cb5ff86575821992ea82c4df5c388ebc (VFS: Fix the
nfs sillyrename regression in kernel 2.6.38).

The patch has been queued for the 2.6.38 stable series.
Comment 3 Jeff Layton 2011-03-16 15:21:12 UTC
Confirmed. It seems to fix the issue.

I think we can go ahead and close this bug.