Bug 28852
Summary: | [KMS] radeon artifacts when switched to graphics during boot | ||
---|---|---|---|
Product: | Drivers | Reporter: | Oldřich Jedlička (oldium.pro) |
Component: | Video(DRI - non Intel) | Assignee: | drivers_video-dri |
Status: | CLOSED CODE_FIX | ||
Severity: | normal | CC: | alexdeucher, florian, maciej.rutecki, rjw |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 2.6.38-rc2 (branch airlied/drm-2.6.git/drm-fixes) | Subsystem: | |
Regression: | Yes | Bisected commit-id: | |
Bug Depends on: | |||
Bug Blocks: | 27352 | ||
Attachments: |
2.6.38 dmesg
2.6.37 dmesg VBIOS `lspci -vnn` with my card Patch that fixes the problem possible fix new patch final patch |
Description
Oldřich Jedlička
2011-02-10 21:11:38 UTC
Here is the video showing the problem: http://problem.oldium.net/radeon.avi Created attachment 47202 [details]
2.6.38 dmesg
Created attachment 47212 [details]
2.6.37 dmesg
It is notebook's LVDS on Mobility Radeon HD 3470. Sorry, mid-air collision. Created attachment 47222 [details]
VBIOS
Can you attach the output of lspci -vnn for your card? The following patches should fix it: http://lists.freedesktop.org/archives/dri-devel/2011-February/007976.html http://lists.freedesktop.org/archives/dri-devel/2011-February/008059.html I've applied both patches and the problem is worse. Created attachment 47242 [details]
`lspci -vnn` with my card
Created attachment 47262 [details]
Patch that fixes the problem
The patch reverts commit "drm/radeon/kms: disable ss fixed ref divide".
I've applied the patch on top of the two patches from the mailing list. I forgot to mention the rest of my hardware - Acer TravelMate 5730G. Does your revert patch work ok without the two mailing list patches? Created attachment 47292 [details]
possible fix
Can you try the following patch against 2.6.38-rc4 or newer and make sure all is working well?
My patch on 2.6.38-rc4 doesn't fix the problem, your patch neither. My patch combined with previous two from mailing list fixes the problem on 2.6.38-rc4. Created attachment 47462 [details]
new patch
Can you try this patch? Try uncommenting the following lines to see if either of those flags work any better. Try them individually and together if possible and report back which, if any, helps.
/*pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP;*/
/*if (ASIC_IS_AVIVO(rdev))
pll->flags |= RADEON_PLL_USE_FRAC_FB_DIV;*/
Results with 2.6.38-rc4 and first/second block uncommented (no=commented, yes=uncommented): first second result ------------------- no no bad (usual) yes no worse no yes good yes yes good The result is that the second block (RADEON_PLL_USE_FRAC_FB_DIV) has to be uncommented on my system. I've tested only LVDS, not any dual-screen configuration. Handled-By : Alex Deucher <alexdeucher@gmail.com> Created attachment 47722 [details]
final patch
The attached patch is what I am proposing goes upstream. Please verify it works properly for you.
(In reply to comment #20) > Created an attachment (id=47722) [details] > final patch > > The attached patch is what I am proposing goes upstream. Please verify it > works properly for you. The patch fixes my problem. Latest kernel from airlied/drm-2.6.git, branch drm-fixes, works fine. Fixed in mainstream 2.6.38-rc5. Thanks! It is safe to mark this bug as RESOLVED. I don't know the correct resolution, though. Fixed by commit 5b40ddf drm/radeon/kms: hopefully fix pll issues for real (v3). |