Bug 284

Summary: Compile failure in drivers/ieee1394/pcilynx.c
Product: Drivers Reporter: Jayce Dowell (jdowell)
Component: IEEE1394Assignee: Ben Collins (bcollins)
Status: CLOSED CODE_FIX    
Severity: normal    
Priority: P2    
Hardware: i386   
OS: Linux   
Kernel Version: 2.5.59 Subsystem:
Regression: --- Bisected commit-id:
Attachments: 2.5.59 .config file
Diff that should fix the problem (not tested on actual ieee1394 hardware)

Description Jayce Dowell 2003-01-17 17:19:56 UTC
Distribution: Mandrake 9.0
Hardware Environment: Athlon-XP
Software Environment: gcc-3.2
Problem Description: Compile failure in driver/ieee1394.c

     gcc -Wp,-MD,drivers/ieee1394/.pcilynx.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe
-mpreferred-stack-boundary=2 -march=athlon -Iinclude/asm-i386/mach-default
-fomit-frame-pointer -nostdinc -iwithprefix include -DMODULE  
-DKBUILD_BASENAME=pcilynx -DKBUILD_MODNAME=pcilynx   -c -o
drivers/ieee1394/pcilynx.o drivers/ieee1394/pcilynx.c
drivers/ieee1394/pcilynx.c:139: warning: initialization from incompatible
pointer type
drivers/ieee1394/pcilynx.c:140: warning: missing braces around initializer
drivers/ieee1394/pcilynx.c:140: warning: (near initialization for `bit_ops.name')
drivers/ieee1394/pcilynx.c:141: warning: initialization makes integer from
pointer without a cast
drivers/ieee1394/pcilynx.c:142: warning: initialization makes integer from
pointer without a cast
drivers/ieee1394/pcilynx.c:143: warning: initialization makes integer from
pointer without a cast
drivers/ieee1394/pcilynx.c:144: warning: initialization makes integer from
pointer without a cast
drivers/ieee1394/pcilynx.c:145: warning: initialization makes integer from
pointer without a cast
drivers/ieee1394/pcilynx.c:145: initializer element is not computable at load time
drivers/ieee1394/pcilynx.c:145: (near initialization for `bit_ops.name[5]')
drivers/ieee1394/pcilynx.c:146: warning: initialization makes integer from
pointer without a cast
drivers/ieee1394/pcilynx.c:146: initializer element is not computable at load time
drivers/ieee1394/pcilynx.c:146: (near initialization for `bit_ops.name[6]')
drivers/ieee1394/pcilynx.c:147: initializer element is not constant
drivers/ieee1394/pcilynx.c:147: (near initialization for `bit_ops.name')
drivers/ieee1394/pcilynx.c: In function `lynx_devctl':
drivers/ieee1394/pcilynx.c:763: warning: `_MOD_INC_USE_COUNT' is deprecated
(declared at include/linux/module.h:429)
drivers/ieee1394/pcilynx.c:765: warning: `__MOD_DEC_USE_COUNT' is deprecated
(declared at include/linux/module.h:404)
make[2]: *** [drivers/ieee1394/pcilynx.o] Error 1
make[1]: *** [drivers/ieee1394] Error 2
make: *** [drivers] Error 2

Steps to reproduce: make dep && make bzImage && make modules
                    .config file attached
Comment 1 Jayce Dowell 2003-01-17 17:20:24 UTC
Created attachment 74 [details]
2.5.59 .config file
Comment 2 James Lamanna 2003-02-05 13:50:36 UTC
Created attachment 97 [details]
Diff that should fix the problem (not tested on actual ieee1394 hardware)

Looks like the struct initializer just needed the field tags to fit with new
ANSI style.
Comment 3 Stacy Woods 2003-04-14 12:06:19 UTC
Does anyone know the status of the above patch?  Does it fix the problem, or has
it made it into the mainline kernel yet?   Please update the status state
accordingly.