Bug 27202

Summary: Remote control of saa7134-based tv card "ASUSTeK P7131 Hybrid" stopped working in 2.6.37
Product: v4l-dvb Reporter: acaizzo
Component: saa7134Assignee: v4l-dvb_saa7134 (v4l-dvb_saa7134)
Status: RESOLVED PATCH_ALREADY_AVAILABLE    
Severity: normal CC: florian, maciej.rutecki, rjw
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 2.6.37 Subsystem:
Regression: Yes Bisected commit-id:
Bug Depends on:    
Bug Blocks: 21782    
Attachments: dmesg of 2.6.37 (not working) kernel
Properly initialize IR raw_event struct

Description acaizzo 2011-01-20 17:23:23 UTC 
Created attachment 44512 [details]
dmesg of 2.6.37 (not working) kernel

The remote control of my TV card stopped working in kernel 2.6.37 (plain, from kernel.org).

The input device appears, but testing it with evtest shows no report of events on keypresses.

The card is a PCI "ASUSTeK P7131 Hybrid", attached to a 32-bit Pentium 4, using driver saa7134.

The remote works correctly in kernel 2.6.36.

Tried git-bisect and got the following result:
-----------
4651918a4afdd49bdea21d2f919b189ef17a6399 is the first bad commit
commit 4651918a4afdd49bdea21d2f919b189ef17a6399
Author: Maxim Levitsky <maximlevitsky@gmail.com>
Date:   Sat Oct 16 19:56:28 2010 -0300

    [media] IR: extend ir_raw_event and do refactoring

    Add new event types for timeout & carrier report
    Move timeout handling from ir_raw_event_store_with_filter to
    ir-lirc-codec, where it is really needed.
    Now lirc bridge ensures proper gap handling.
    Extend lirc bridge for carrier & timeout reports

    Note: all new ir_raw_event variables now should be initialized
    like that: DEFINE_IR_RAW_EVENT(ev);
Comment 1 Rafael J. Wysocki 2011-01-20 20:37:04 UTC 
First-Bad-Commit : 4651918a4afdd49bdea21d2f919b189ef17a6399
Comment 2 Mauro Carvalho Chehab 2011-01-20 21:13:03 UTC 
Created attachment 44532 [details]
Properly initialize IR raw_event struct

Please test this patch. It should fix the regression.
Comment 3 acaizzo 2011-01-21 05:40:26 UTC 
(In reply to comment #2)
> Created an attachment (id=44532) [details]
> Properly initialize IR raw_event struct
> 
> Please test this patch. It should fix the regression.

I confirm that the patch fixes the problem.

Thank you!
Comment 4 Florian Mickler 2011-01-24 13:25:16 UTC 
Patch: https://bugzilla.kernel.org/attachment.cgi?id=44532
Comment 5 Rafael J. Wysocki 2011-02-21 22:21:23 UTC 
Handled-By : Mauro Carvalho Chehab <mchehab@redhat.com>