Bug 2708
Summary: | (IRDA) spin_lock already locked in sir_dev.c | ||
---|---|---|---|
Product: | Drivers | Reporter: | Tom Parker (tom) |
Component: | Network | Assignee: | Jeff Garzik (jgarzik) |
Status: | CLOSED CODE_FIX | ||
Severity: | high | CC: | bunk, domen, jt |
Priority: | P2 | ||
Hardware: | i386 | ||
OS: | Linux | ||
Kernel Version: | 2.6.6 | Subsystem: | |
Regression: | --- | Bisected commit-id: | |
Attachments: | Add missing spin_unlock |
Description
Tom Parker
2004-05-14 04:12:02 UTC
Created attachment 2863 [details]
Add missing spin_unlock
It adds missing spinlock on what seems like an error path, so device might
still not work, but it should get rid of that "already locked" message.
The attached patch means I get no complaints about spin locks in the log. However I am still unable to sync with my phone.;;echo 9600 > /proc/sys/net/irda/max_baud_rate;;seems to fix that problem (although syncing takes longer).;;I tried the same irda dongle with debian stable and 2.4.26 on a different motherboard and got a kernel panic about sheduling in an interrupt. Should I do a full report on that here, or open a new bug? see bug 2779 for this kernel panic with this device on 2.4.26. To reiterate, the patch attached to this bug does fix the problems on 2.6.6 (although the device does have to be slowed down to operate) What is the status of this issue in recent 2.6 kernels? The missing spinlock restore is in the latest 2.6 kernels. |