Bug 25702

Summary:	[cppcheck] found regression due to missing "{"
Product:	Process Management	Reporter:	Martin Ettl (ettl.martin)
Component:	Other	Assignee:	process_other
Status:	CLOSED CODE_FIX
Severity:	normal	CC:	dhowells, florian
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	linux-2.6	Subsystem:
Regression:	Yes	Bisected commit-id:
Attachments:	proposed patch to fix the issue

Description Martin Ettl 2010-12-27 12:39:43 UTC

cppcheck, a static code analysis tool (http://sourceforge.net/projects/cppcheck/). It found a regression in file linux-2.6/arch/mn10300/kernel/irq.c. This only happens when the preprocessor define 
CONFIG_HOTPLUG_CPU is set. Please refer the attached patch that fixes the issue.

Best regards from the cppcheck team

Martin

Comment 1 Martin Ettl 2010-12-27 12:40:59 UTC

Created attachment 41712 [details]
proposed patch to fix the issue

Comment 2 Florian Mickler 2011-01-24 12:57:26 UTC

a fix for this has been merged in 2.6.37:
commit d9a1abe4844e7591cd82e167a1a09e6546f6c45e
Author: Andrew Morton <akpm@linux-foundation.org>
Date:   Mon Jan 3 14:59:11 2011 -0800

    arch/mn10300/kernel/irq.c: fix build