Bug 25442

Summary:	ixp4xx defines FREQ macro; conflicts with gspca/ov519 driver
Product:	Platform Specific/Hardware	Reporter:	Ben Hutchings (ben)
Component:	ARM	Assignee:	linux-arm-kernel (linux-arm-kernel)
Status:	CLOSED CODE_FIX
Severity:	normal	CC:	akpm, florian, maciej.rutecki, rjw
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	2.6.37-rc5	Subsystem:
Regression:	Yes	Bisected commit-id:
Bug Depends on:
Bug Blocks:	21782
Attachments:	patch to rename FREQ macro

Description Ben Hutchings 2010-12-22 02:02:42 UTC

Created attachment 41252 [details]
patch to rename FREQ macro

When building for the ARM IXP4xx platform, <linux/timex.h> ends up including
arch/arm/mach-ixp4xx/include/mach/timex.h which defines the macro FREQ.  This conflicts with use of FREQ as an enumerator in drivers/media/video/gspca/ov519.c.

Since the macro is platform-specific, its name really ought to be given a suitable prefix to avoid such conflicts.

Previously reported with patch at
<http://article.gmane.org/gmane.linux.ports.arm.kernel/99147>

Comment 1 Andrew Morton 2010-12-22 02:17:08 UTC

Please don't send patches via bugzilla - it causes lots of problems with
our usual patch management and review processes.

Please send this patch via email as per Documentation/SubmittingPatches. 
Suitable recipients may be found via scripts/get_maintainer.pl.  Please
also cc myself on the email.

Thanks.

Comment 2 Ben Hutchings 2010-12-22 03:02:25 UTC

(In reply to comment #1)
> Please don't send patches via bugzilla - it causes lots of problems with
> our usual patch management and review processes.

As I said, the patch was already sent by mail; I'm just repeating it here.

Comment 3 Rafael J. Wysocki 2010-12-22 12:18:02 UTC

Patch : https://bugzilla.kernel.org/attachment.cgi?id=41252
Handled-By : Ben Hutchings <ben@decadent.org.uk>

Comment 4 Rafael J. Wysocki 2011-02-12 23:10:43 UTC

Fixed by commit e66a022a80d73b1a5d2e02c9db2c42e8b9853b40 .