Bug 2474

Summary:	SNDRV_DMA_TYPE_PCI should be SNDRV_DMA_TYPE_DEV ... breaks sparc audio
Product:	Drivers	Reporter:	Jeremy Huddleston (jeremyhu)
Component:	Sound(ALSA)	Assignee:	Jaroslav Kysela (perex)
Status:	CLOSED CODE_FIX
Severity:	high	CC:	bunk
Priority:	P2
Hardware:	i386
OS:	Linux
Kernel Version:	2.6.5-rc1	Subsystem:
Regression:	---	Bisected commit-id:
Attachments:	linux-2.6.5-rc1.sndfix.patch

Description Jeremy Huddleston 2004-04-08 09:44:18 UTC

See http://www.ussg.iu.edu/hypermail/linux/kernel/0403.2/0084.html

2.6.5-r1 uses SNDRV_DMA_TYPE_PCI where it should be SNDRV_DMA_TYPE_DEV.

sed -i 's/SNDRV_DMA_TYPE_PCI/SNDRV_DMA_TYPE_DEV/g' include/sound/trident.h
sound/isa/cs423x/cs4231_lib.c sound/sparc/cs4231.c sound/parisc/harmony.c

/usr/src/linux $ grep -R SNDRV_DMA_TYPE_PCI .
./include/sound/trident.h:#define TRIDENT_DMA_TYPE        SNDRV_DMA_TYPE_PCI_16MB
./include/sound/trident.h:#define TRIDENT_DMA_TYPE        SNDRV_DMA_TYPE_PCI
./sound/isa/cs423x/cs4231_lib.c:               
snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_PCI,
./sound/sparc/cs4231.c:         snd_pcm_lib_preallocate_pages_for_all(pcm,
SNDRV_DMA_TYPE_PCI,
./sound/parisc/harmony.c:       harmony->dma_dev.type = SNDRV_DMA_TYPE_PCI;

Comment 1 Jeremy Huddleston 2004-04-08 09:59:01 UTC

Created attachment 2554 [details]
linux-2.6.5-rc1.sndfix.patch

This patch corrects the problem stated above as well as a parse error in one of
the affected files.

Comment 2 Adrian Bunk 2005-07-05 10:58:33 UTC

This issue is already fixed in current 2.6 kernels.