Bug 24672

Summary: [hid-ORTEK] Enable GeneralKeys keyboard - Mouse Combi PX-253
Product: Drivers Reporter: Fabian Schuh (mail)
Component: USBAssignee: Greg Kroah-Hartman (greg)
Status: RESOLVED INVALID    
Severity: normal CC: d.bell, info
Priority: P1    
Hardware: All   
OS: Linux   
URL: https://bugs.archlinux.org/task/22030#comment69610
Kernel Version: 2.6.36 Subsystem:
Regression: No Bisected commit-id:
Attachments: USB resource descriptor fix for Ortek PKB-1700 devices

Description Fabian Schuh 2010-12-11 11:12:00 UTC 
Hi developers,

i request a small change to the add support for the Keyboard/Mouse Combi device PX-253 from ortek. I seems that it is working well with the already developed driver, but does not register correctly to it as it uses a sligthly different device id.

Searching through the web i found a 'patch' at ubuntuusers.de:
<http://forum.ubuntuusers.de/topic/generalkeys-tastatur-maus-kombi-px-2537-675-o/#post-2626390>
and summed the content up at my distributions bug tracker:
<https://bugs.archlinux.org/task/22030>
They told me to add a feature request in the official bugtracker, what I am doing right now.

Unfortunatelly I do not know how to do a patch/diff file with multiple modifications in different files, so I am summarizing the changes:
=================
- All files lie in "/usr/src/linux/drivers/hid"
- in "hid-ids.h" add:
#define USB_DEVICE_ID_ORTEK_PKB1700 0x1700 // neu hinzufuegen
- in "hid-ortek.c" modify:
dev_info(&hdev->dev, "Fixing up Ortek WKB-2000/PKB-1700 "
- in "Kconfig":
Support for Ortek WKB-2000/PKB-1700 wireless keyboard + mouse trackpad.
- in "hid-core.c" add
{ HID_USB_DEVICE(USB_VENDOR_ID_ORTEK, USB_DEVICE_ID_ORTEK_PKB1700) },
- and finally in "hid-ortek.c"
{ HID_USB_DEVICE(USB_VENDOR_ID_ORTEK, USB_DEVICE_ID_ORTEK_PKB1700) },
=================

Thanks for concidering my request.

Grettings
 -- Fabian
Comment 1 Johan 2011-01-05 09:17:20 UTC 
Created attachment 42392 [details]
USB resource descriptor fix for Ortek PKB-1700 devices

I have a wireless keyboard with a pointing stick, branded as "Plexgear Mediatrack Mini Comfort" which looks like this:

http://www.kjell.com/?item=91814&path=97000000,192500000,202500000,205500000,207000000

This device also identifies itself as PKB-1700 and I've created a patch which seems to be almost identical to your proposed solution.

Please test this patch with your device.
Comment 2 David Bell 2011-02-26 19:55:13 UTC 
Hi, the attached patch (id=42392) in comment #1 worked for me against 2.6.37.2, the keyboard now works correctly :)

Please apply upstream if possible since the patch works against the model in question.

Cheers!
Comment 3 Greg Kroah-Hartman 2012-02-22 21:53:43 UTC 
All USB bugs should be sent to the linux-usb@vger.kernel.org mailing 
list, and not entered into bugzilla.  Please bring this issue up there,
if it is still a problem in the latest kernel release.
Comment 4 Jimob 2022-10-01 14:56:11 UTC 
(In reply to Johan from comment #1)
> Created attachment 42392 [details]
> USB resource descriptor fix for Ortek PKB-1700 devices
> 
> I have a wireless keyboard with a pointing stick, branded as "Plexgear
> Mediatrack Mini Comfort" which looks like this:
> 
>
> http://www.lagaiphone.se/?item=91814&path=97000000,192500000,202500000,205500000,
> 207000000
> 
> This device also identifies itself as PKB-1700 and I've created a patch
> which seems to be almost identical to your proposed solution.

Please test this patch with your device.