Bug 22932

try reverting this commit: 3e384ee6c687cb397581ee8f9440fc8220cfac80
"ACPI / PM: Fix reference counting of power resources"

Already I run patch from Zhang Rui (http://marc.info/?l=linux-kernel&m=128987068408102&w=2). When I finish then I will revert commit above.

(In reply to comment #1)
> try reverting this commit: 3e384ee6c687cb397581ee8f9440fc8220cfac80
> "ACPI / PM: Fix reference counting of power resources"

You probably have right. Revert this commit seems solve problem.

Regards

Caused by:

commit 3e384ee6c687cb397581ee8f9440fc8220cfac80
Author: Rafael J. Wysocki <rjw@sisk.pl>
Date:   Fri Oct 22 02:35:54 2010 +0200

    ACPI / PM: Fix reference counting of power resources

    Reported-by: Matthew Garrett <mjg@redhat.com>
    Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    Signed-off-by: Len Brown <len.brown@intel.com>

First-Bad-Commit : 3e384ee6c687cb397581ee8f9440fc8220cfac80

Please try if applying the following three patches on top of the
failing commit fixes the problem:

https://patchwork.kernel.org/patch/287542/
https://patchwork.kernel.org/patch/287562/
https://patchwork.kernel.org/patch/287552/

I try apply these patches on 2.6.37-rc1, but patches won't apply correctly:

root@gumis:/usr/src/linux-2.6.37-rc1# patch -p1 < RFC-RFT-1-3-ACPI-PM-Register-acpi_power_driver-early.patch 
patching file drivers/acpi/bus.c
Hunk #1 FAILED at 1025.
1 out of 1 hunk FAILED -- saving rejects to file drivers/acpi/bus.c.rej
patching file drivers/acpi/scan.c
Hunk #1 succeeded at 1550 (offset 7 lines).
root@gumis:/usr/src/linux-2.6.37-rc1# patch -p1 < RFC-RFT-2-3-ACPI-PM-Register-power-resource-devices-as-soon-as-they-are-needed.patch 
patching file drivers/acpi/scan.c
Hunk #1 succeeded at 827 (offset 9 lines).
Hunk #2 succeeded at 857 (offset 9 lines).
Hunk #3 succeeded at 1312 (offset 2 lines).
root@gumis:/usr/src/linux-2.6.37-rc1# patch -p1 < RFC-RFT-3-3-ACPI-PM-Fix-initial-reference-counting-of-power-resources.patch 
patching file drivers/acpi/scan.c
Hunk #1 succeeded at 889 (offset 9 lines).
root@gumis:/usr/src/linux-2.6.37-rc1#

So I manually edit drivers/acpi/bus.c and remove acpi_power_init(); from static int __init acpi_init(void). Should use another kernel?

After the reboot & s2ram I have still the same problem.

OK, thanks for testing.

I'll try to figure out what's wrong in the next few of days.

Created attachment 37372 [details]
ACPI / power: Do not reference count power resources without checking state

Can you check if this patch (without the previous 3 patches) on top of the
failing commit makes any difference?

(In reply to comment #8)
> Created an attachment (id=37372) [details]
> ACPI / power: Do not reference count power resources without checking state
> 
> Can you check if this patch (without the previous 3 patches) on top of the
> failing commit makes any difference?

Tested 2 times when CPU temperature is below 1st trip point (CPU=40*C vs. trip point=45*C) and seems be OK.

Tested on 2.6.37-rc1 + yours patch.

Thanks

Thanks for testing.

This patch may be sufficient for 2.6.37, but I think more changes will be
necessary in general, so I'll have some more patches to test if you don't
mind.

Handled-By : Rafael J. Wysocki <rjw@sisk.pl>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=37372

(In reply to comment #10)
> Thanks for testing.
> 
> This patch may be sufficient for 2.6.37, but I think more changes will be
> necessary in general, so I'll have some more patches to test if you don't
> mind.

I don't see any problem test another yours patches. I will wait for it.

Regards

Created attachment 37822 [details]
ACPI: Rework PM routines related to power resources

Please test if your machine behaves correctly with this patch applied
(on top of the current mainline kernel).

(In reply to comment #13)
> Created an attachment (id=37822) [details]
> ACPI: Rework PM routines related to power resources
> 
> Please test if your machine behaves correctly with this patch applied
> (on top of the current mainline kernel).

Works OK. Fan doesn't run on full speed, but seed depends on current temperature, as should. You can add "Tested-by" for your patch.

Thanks for help

Ignore-Patch : https://bugzilla.kernel.org/attachment.cgi?id=37822
Patch : https://patchwork.kernel.org/patch/354682/

Ignore-Patch : https://bugzilla.kernel.org/attachment.cgi?id=37372

Bug still present in -rc4. When patch from https://bugzilla.kernel.org/show_bug.cgi?id=22932#c13 will be add to 2.6.37?

Bug still present in -rc5

I use kernel 2.6.37-rc5+ and notice bug describe in this issue. I apply patch 37372 and for 2 days seems to be OK, but today when I resume my laptop (after suspend it to ram) fan are noise again. I suspend it another one, after one minute, and resume again and then everything are OK. I think, that patch 37372 is not complete, and sometimes did not work properly.

Have you tested the patch from comment #13 ?

No. This one I don't apply, but I'll do it now. Is patch from comment #13 (37822) should be apply instead of patch from comment #8 (37372) ?

The patch from comment #8 is a minimal fix for 2.6.37, but the one from
comment #13 is what we're going to do eventually in 2.6.38, more or less.

I applied patch from comment #13 and kernel doesn't compile now. The error is as follows:

  CC [M]  drivers/platform/x86/fujitsu-laptop.o
drivers/platform/x86/fujitsu-laptop.c: In function 'acpi_fujitsu_add':
drivers/platform/x86/fujitsu-laptop.c:692: error: implicit declaration of function 'acpi_bus_get_power'

Created attachment 39882 [details]
Platform / x86: Make fujitsu_laptop use acpi_bus_update_power()

It looks like you need this patch in addition.

Now (after patch from comment #24) is much better. Kernel compiled correctly and looks like it works, but I will be observe it and report how it works.

Thanks for help.

I still use this patch, and everything is OK. Today I applied it on kernel 2.6.37-rc6 and I will be watch is resume work properly.

Clean 2.6.37-rc6 seems work OK.

Thanks

I think we can close this bug, because the most annoying symptoms are
fixed by:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=212967c69afd348342548272aedbe4d46a9325d6

and the overall power resources rework is slated for 2.6.38.