Bug 219934

Summary:	Missing null check in aspeed_lpc_enable_snoop
Product:	Drivers	Reporter:	henry (bsdhenrymartin)
Component:	Platform	Assignee:	Jean Delvare (jdelvare)
Status:	ASSIGNED ---
Severity:	normal
Priority:	P3
Hardware:	All
OS:	Linux
Kernel Version:		Subsystem:
Regression:	No	Bisected commit-id:

Description henry 2025-03-28 08:01:45 UTC

soc: aspeed: Add NULL check in aspeed_lpc_enable_snoop

devm_kasprintf() can return a NULL pointer on failure,but this lpc_snoop->chan[channel].miscdev.name returned value in aspeed_lpc_enable_snoop is not checked.
Add NULL check in aspeed_lpc_enable_snoop, to handle kernel NULL pointer dereference error.

Comment 1 Jean Delvare 2025-04-03 10:58:49 UTC

This missing NULL check is only the tip of the iceberg, the aspeed-lpc-snoop driver driver has many other issues in error code paths (resource leak) and device removal path (race condition). I reported my findings to the subsystem maintainers.