Bug 219224

Summary:	Laptop Internal Keyboard not working on ASUS VivoBook E1404GA on ubuntu 24.04.
Product:	Drivers	Reporter:	Tom (bugzilla)
Component:	Input Devices	Assignee:	drivers_input-devices
Status:	NEW ---
Severity:	normal	CC:	bugzilla, jwrdegoede, pmenzel+bugzilla.kernel.org, tamim
Priority:	P3
Hardware:	All
OS:	Linux
Kernel Version:		Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	DMESG ACPI: resource: Skip IRQ override on Asus Vivobook Go E1404GA dmidecode.txt dsdt.dat

Description Tom 2024-09-03 11:24:01 UTC

Created attachment 306810 [details]
DMESG

I am following several bugs for ASUS VivoBook laptops which have a non-working internal keyboard. 

Adding this model to the quirks list in `drivers/acpi/resource.c` with a match on the board name with my model E1404GA causes the internel keyboard to work again, however I would have to patch my own kernel every update which gets tedious quickly. 

I would be thankful if this model could be included in the list in future kernel versions.

I commented in https://bugzilla.kernel.org/show_bug.cgi?id=216158.

@Paul Menzel asked me to file a new issue and CC him (I will try to do that) and to also add the output of dmesg, which I did and attached to this bug.

Comment 1 Paul Menzel 2024-09-09 18:53:18 UTC

Created attachment 306843 [details]
ACPI: resource: Skip IRQ override on Asus Vivobook Go E1404GA

The DMI string is:

    [    0.000000] DMI: ASUSTeK COMPUTER INC. Vivobook Go E1404GA_E1404GA/E1404GA, BIOS E1404GA.302 08/23/2023

Please also *attach* the output of `dmidecode` and `dsdt.dat` from the commands below:

    $ sudo dmidecode > dmidecode.txt
    $ sudo cat /sys/firmware/acpi/tables/DSDT > dsdt.dat
    $ iasl -d dsdt.dat
    $ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1

Please find a preliminary patch attached.

Comment 2 Tom 2024-09-10 08:50:51 UTC

Created attachment 306847 [details]
dmidecode.txt

Comment 3 Tom 2024-09-10 08:51:12 UTC

Created attachment 306848 [details]
dsdt.dat

Comment 4 Tom 2024-09-10 08:51:38 UTC

I added these files @PaulMenzel

Comment 5 Paul Menzel 2024-09-11 08:19:28 UTC

Thank you. (I am Cc’ed to the report, so no need for comment#4 in the future. ;-))

I sent the patch [1]. The diff is the same to the attached one here, but the commit message is amended.

It’d be great if you could test the patch.

[1]: https://lore.kernel.org/linux-acpi/20240911081612.3931-1-pmenzel@molgen.mpg.de/T/#u

Comment 6 Paul Menzel 2024-09-11 08:23:39 UTC

It’d be also great if you reported the issue to the ASUS. The chances they are going to fix it are low, but if enough reports show up in their issue tracker, they might fix it.

Comment 7 Tom 2024-09-12 08:59:44 UTC

(In reply to Paul Menzel from comment #5)
> Thank you. (I am Cc’ed to the report, so no need for comment#4 in the
> future. ;-))
> 
> I sent the patch [1]. The diff is the same to the attached one here, but the
> commit message is amended.
> 
> It’d be great if you could test the patch.
> 
> [1]:
> https://lore.kernel.org/linux-acpi/20240911081612.3931-1-pmenzel@molgen.mpg.
> de/T/#u

Tested and the patch fixes the issue! What kernel version do you reckon I can find this fix? 

Thanks for everything

Comment 8 Paul Menzel 2024-09-12 10:41:15 UTC

Thank you for testing. It’d be great if you replied to the patch email I sent yesterday with the tag below:

Tested-by: Your Name <your@email>

Hopefully it’s going to be picked up for the next merge window, so Linux 6.12. But now promises.

Comment 9 Hans de Goede 2024-09-27 14:29:20 UTC

Tom, Thank you for fixing this.

Paul, thank you for writing a patch for this. I have submitted an alternative fix for this loosing an existing DMI match instead:

https://lore.kernel.org/linux-acpi/20240927141606.66826-2-hdegoede@redhat.com/

The new entry which you submitted would have covered both models anyways (because of DMI_MATCH() substring matching), so just loosing the existing quirk is better.