Bug 219117

Summary:	amdgpu: amdgpu_device_ip_init failed
Product:	Drivers	Reporter:	Jean-Christophe Guillain (jean-christophe)
Component:	Video(DRI - non Intel)	Assignee:	drivers_video-dri
Status:	RESOLVED CODE_FIX
Severity:	blocking	CC:	jean-christophe, tim.huang, vasant.hegde
Priority:	P3
Hardware:	All
OS:	Linux
Kernel Version:	6.11.0-rc1	Subsystem:
Regression:	Yes	Bisected commit-id:	064d92436b6924937ef414894d9174fa4465f788

Description Jean-Christophe Guillain 2024-08-01 12:14:39 UTC

Hello !

Since the last kernel RC (6.11-rc1), the boot process hangs on my computer after a GPU error :

Jul 30 10:18:10 youpi kernel: amdgpu 0000:00:01.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring gfx test failed (-110)
Jul 30 10:18:10 youpi kernel: [drm:amdgpu_device_init [amdgpu]] *ERROR* hw_init of IP block <gfx_v8_0> failed -110
Jul 30 10:18:10 youpi kernel: amdgpu 0000:00:01.0: amdgpu: amdgpu_device_ip_init failed
Jul 30 10:18:10 youpi kernel: amdgpu 0000:00:01.0: amdgpu: Fatal error during GPU init
Jul 30 10:18:10 youpi kernel: amdgpu 0000:00:01.0: amdgpu: amdgpu: finishing device.
Jul 30 10:18:10 youpi kernel: ------------[ cut here ]------------
Jul 30 10:18:10 youpi kernel: WARNING: CPU: 0 PID: 186 at drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:631 amdgpu_irq_put+0x45/0x70 [amdgpu]
Jul 30 10:18:10 youpi kernel: Modules linked in: sd_mod usbhid uas hid usb_storage amdgpu(+) amdxcp drm_exec gpu_sched drm_buddy i2c_algo_bit drm_suballoc_helper drm>
Jul 30 10:18:10 youpi kernel: CPU: 0 UID: 0 PID: 186 Comm: (udev-worker) Not tainted 6.11.0-rc1-jcg+ #1
Jul 30 10:18:10 youpi kernel: Hardware name: LENOVO 10VGS02P00/3130, BIOS M1XKT57A 02/10/2022
Jul 30 10:18:10 youpi kernel: RIP: 0010:amdgpu_irq_put+0x45/0x70 [amdgpu]
Jul 30 10:18:10 youpi kernel: Code: 48 8b 4e 10 48 83 39 00 74 2c 89 d1 48 8d 04 88 8b 08 85 c9 74 14 f0 ff 08 b8 00 00 00 00 74 05 e9 50 c5 f7 d8 e9 6b fd ff ff <0f>
Jul 30 10:18:10 youpi kernel: RSP: 0018:ffffaf1480677940 EFLAGS: 00010246
Jul 30 10:18:10 youpi kernel: RAX: ffff94f286417540 RBX: ffff94f285818880 RCX: 0000000000000000
Jul 30 10:18:10 youpi kernel: RDX: 0000000000000000 RSI: ffff94f2858254c0 RDI: ffff94f285800000
Jul 30 10:18:10 youpi kernel: RBP: ffff94f285810208 R08: 0000000000000002 R09: 0000000000000003
Jul 30 10:18:10 youpi kernel: R10: ffffaf1480677768 R11: ffffffff9a4c96c8 R12: ffff94f2858105e8
Jul 30 10:18:10 youpi kernel: R13: ffff94f285800010 R14: ffff94f285800000 R15: ffff94f2858254c0
Jul 30 10:18:10 youpi kernel: FS:  00007f03450bb8c0(0000) GS:ffff94f317600000(0000) knlGS:0000000000000000
Jul 30 10:18:10 youpi kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
Jul 30 10:18:10 youpi kernel: CR2: 00007f03450b2028 CR3: 00000001458d8000 CR4: 00000000001506f0
Jul 30 10:18:10 youpi kernel: Call Trace:
Jul 30 10:18:10 youpi kernel:  <TASK>
Jul 30 10:18:10 youpi kernel:  ? __warn+0x7c/0x120
Jul 30 10:18:10 youpi kernel:  ? amdgpu_irq_put+0x45/0x70 [amdgpu]
Jul 30 10:18:10 youpi kernel:  ? report_bug+0x155/0x170
Jul 30 10:18:10 youpi kernel:  ? handle_bug+0x3f/0x80
Jul 30 10:18:10 youpi kernel:  ? exc_invalid_op+0x13/0x60
Jul 30 10:18:10 youpi kernel:  ? asm_exc_invalid_op+0x16/0x20
Jul 30 10:18:10 youpi kernel:  ? amdgpu_irq_put+0x45/0x70 [amdgpu]
Jul 30 10:18:10 youpi kernel:  amdgpu_fence_driver_hw_fini+0xfa/0x130 [amdgpu]
Jul 30 10:18:10 youpi kernel:  amdgpu_device_fini_hw+0xa2/0x3f0 [amdgpu]
Jul 30 10:18:10 youpi kernel:  amdgpu_driver_load_kms+0x79/0xb0 [amdgpu]
Jul 30 10:18:10 youpi kernel:  amdgpu_pci_probe+0x195/0x520 [amdgpu]
Jul 30 10:18:10 youpi kernel:  local_pci_probe+0x41/0x90
Jul 30 10:18:10 youpi kernel:  pci_device_probe+0xbb/0x1e0
Jul 30 10:18:10 youpi kernel:  really_probe+0xd6/0x390
Jul 30 10:18:10 youpi kernel:  ? __pfx___driver_attach+0x10/0x10
Jul 30 10:18:10 youpi kernel:  __driver_probe_device+0x78/0x150
Jul 30 10:18:10 youpi kernel:  driver_probe_device+0x1f/0x90
Jul 30 10:18:10 youpi kernel:  __driver_attach+0xce/0x1c0
Jul 30 10:18:10 youpi kernel:  bus_for_each_dev+0x84/0xd0
Jul 30 10:18:10 youpi kernel:  bus_add_driver+0x10e/0x240
Jul 30 10:18:10 youpi kernel:  driver_register+0x55/0x100
Jul 30 10:18:10 youpi kernel:  ? __pfx_amdgpu_init+0x10/0x10 [amdgpu]
Jul 30 10:18:10 youpi kernel:  do_one_initcall+0x57/0x320
Jul 30 10:18:10 youpi kernel:  do_init_module+0x60/0x230
Jul 30 10:18:10 youpi kernel:  init_module_from_file+0x86/0xc0
Jul 30 10:18:10 youpi kernel:  idempotent_init_module+0x11b/0x2b0
Jul 30 10:18:10 youpi kernel:  __x64_sys_finit_module+0x5a/0xb0
Jul 30 10:18:10 youpi kernel:  do_syscall_64+0x7e/0x190
Jul 30 10:18:10 youpi kernel:  ? syscall_exit_to_user_mode+0xc/0x1d0
Jul 30 10:18:10 youpi kernel:  ? do_syscall_64+0x8a/0x190
Jul 30 10:18:10 youpi kernel:  ? do_syscall_64+0x8a/0x190
Jul 30 10:18:10 youpi kernel:  ? syscall_exit_to_user_mode+0xc/0x1d0
Jul 30 10:18:10 youpi kernel:  ? do_syscall_64+0x8a/0x190
Jul 30 10:18:10 youpi kernel:  ? syscall_exit_to_user_mode+0xc/0x1d0
Jul 30 10:18:10 youpi kernel:  ? do_syscall_64+0x8a/0x190
Jul 30 10:18:10 youpi kernel:  ? do_syscall_64+0x8a/0x190
Jul 30 10:18:10 youpi kernel:  ? do_syscall_64+0x8a/0x190
Jul 30 10:18:10 youpi kernel:  entry_SYSCALL_64_after_hwframe+0x76/0x7e
Jul 30 10:18:10 youpi kernel: RIP: 0033:0x7f0344f0f719
Jul 30 10:18:10 youpi kernel: Code: 08 89 e8 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48>
Jul 30 10:18:10 youpi kernel: RSP: 002b:00007ffcfd2cf3e8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
Jul 30 10:18:10 youpi kernel: RAX: ffffffffffffffda RBX: 000055e7ba5a8370 RCX: 00007f0344f0f719
Jul 30 10:18:10 youpi kernel: RDX: 0000000000000000 RSI: 00007f03450b3efd RDI: 0000000000000017
Jul 30 10:18:10 youpi kernel: RBP: 00007f03450b3efd R08: 0000000000000000 R09: 000055e7ba58a1d0
Jul 30 10:18:10 youpi kernel: R10: 0000000000000017 R11: 0000000000000246 R12: 0000000000020000
Jul 30 10:18:10 youpi kernel: R13: 0000000000000000 R14: 000055e7ba5a6f20 R15: 00007ffcfd2cf620
Jul 30 10:18:10 youpi kernel:  </TASK>
Jul 30 10:18:10 youpi kernel: ---[ end trace 0000000000000000 ]---
Jul 30 10:18:10 youpi kernel: ------------[ cut here ]------------



I bisected this issue to the commit :
[064d92436b6924937ef414894d9174fa4465f788] drm/amd/pm: avoid to load smu firmware for APUs
Author: Tim Huang <Tim.Huang@amd.com>
Date:   Thu Jun 13 10:34:13 2024 +0800

    drm/amd/pm: avoid to load smu firmware for APUs
    
    Certain call paths still load the SMU firmware for APUs,
    which needs to be skipped.
    
    Signed-off-by: Tim Huang <Tim.Huang@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 8 +++-----
 drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 8 +++-----
 drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 8 +++-----
 drivers/gpu/drm/amd/pm/amdgpu_dpm.c    | 2 +-
 4 files changed, 10 insertions(+), 16 deletions(-)


My PC :
Lenovo ThinkCentre M715q
00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Wani [Radeon R5/R6/R7 Graphics] (rev e4)


Let me now if you need more information.

Cheers,
jC

Comment 1 Artem S. Tashkinov 2024-08-01 17:23:04 UTC

Please report here instead: https://gitlab.freedesktop.org/drm/amd/-/issues

Comment 2 Tim Huang 2024-08-02 02:14:04 UTC

Hello, 

Thanks Jean for reporting this issue.  

It should be the same issue with this one https://gitlab.freedesktop.org/drm/amd/-/issues/3502.   

Here is the fix patch https://gitlab.freedesktop.org/agd5f/linux/-/commit/f1127b0b6ef8d451eddfecb67e4289ce763b2f9e. 

Thanks.
Tim Huang

Comment 3 Jean-Christophe Guillain 2024-08-02 09:15:39 UTC

Hello Tim !

I confirm that your patch fixed the issue.

Thank you very much,
jC