Bug 219010
| Summary: | [REGRESSION][VFIO] kernel 6.9.7 causing qemu crash because of "Collect hot-reset devices to local buffer" | ||
|---|---|---|---|
| Product: | Virtualization | Reporter: | Žilvinas Žaltiena (zaltys) |
| Component: | kvm | Assignee: | virtualization_kvm |
| Status: | RESOLVED CODE_FIX | ||
| Severity: | normal | CC: | beldzhang, holland, regressions, zaltys |
| Priority: | P3 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | Subsystem: | ||
| Regression: | No | Bisected commit-id: | |
|
Description
Žilvinas Žaltiena
2024-07-06 16:30:57 UTC
Additional information: passing NVIDIA GPU, Samsung NVMEs works, passing Fresco FL1100 based USB card does not work. Fresco card is single VF device, but like that sound card it does not report FLR. Reverting "vfio/pci: Collect hot-reset devices to local buffer" allows to pass every mentioned device. Does the problem happen with 6.10-rc6 or newer as well? On 2024/7/7 01:19, bugzilla-daemon@kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=219010 > > --- Comment #1 from Žilvinas Žaltiena (zaltys@natrix.lt) --- > Additional information: passing NVIDIA GPU, Samsung NVMEs works, passing > Fresco > FL1100 based USB card does not work. Fresco card is single VF device, but > like > that sound card it does not report FLR. Reverting "vfio/pci: Collect > hot-reset > devices to local buffer" allows to pass every mentioned device. > It appears that the count is used without init.. And it does not happen with other devices as they have FLR, hence does not trigger the hotreset info path. Please try below patch to see if it works. From 93618efe933c4fa5ec453bddacdf1ca2ccbf3751 Mon Sep 17 00:00:00 2001 From: Yi Liu <yi.l.liu@intel.com> Date: Tue, 9 Jul 2024 06:41:02 -0700 Subject: [PATCH] vfio/pci: Fix a regresssion Signed-off-by: Yi Liu <yi.l.liu@intel.com> --- drivers/vfio/pci/vfio_pci_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c index 59af22f6f826..0a7bfdd08bc7 100644 --- a/drivers/vfio/pci/vfio_pci_core.c +++ b/drivers/vfio/pci/vfio_pci_core.c @@ -1260,7 +1260,7 @@ static int vfio_pci_ioctl_get_pci_hot_reset_info( struct vfio_pci_hot_reset_info hdr; struct vfio_pci_fill_info fill = {}; bool slot = false; - int ret, count; + int ret, count = 0; if (copy_from_user(&hdr, arg, minsz)) return -EFAULT; after manual modify source code: testing pass, that crash is not occurs again. nv 3060ti on dell precision T7920 kernel 6.6.38 qemu 8.2.4 (In reply to Liu, Yi L from comment #3) > It appears that the count is used without init.. And it does not happen > with other devices as they have FLR, hence does not trigger the hotreset > info path. Please try below patch to see if it works. > Patch fixes the problem on my system. On 2024/7/10 04:49, bugzilla-daemon@kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=219010 > > --- Comment #5 from Žilvinas Žaltiena (zaltys@natrix.lt) --- > (In reply to Liu, Yi L from comment #3) >> It appears that the count is used without init.. And it does not happen >> with other devices as they have FLR, hence does not trigger the hotreset >> info path. Please try below patch to see if it works. >> > > Patch fixes the problem on my system. > patch submitted to mailing list. Thanks, and feel free to let me know if it is proper to add your reported-by, and add your tested-by. On 2024/7/10 08:48, Yi Liu wrote: > On 2024/7/10 04:49, bugzilla-daemon@kernel.org wrote: >> https://bugzilla.kernel.org/show_bug.cgi?id=219010 >> >> --- Comment #5 from Žilvinas Žaltiena (zaltys@natrix.lt) --- >> (In reply to Liu, Yi L from comment #3) >>> It appears that the count is used without init.. And it does not happen >>> with other devices as they have FLR, hence does not trigger the hotreset >>> info path. Please try below patch to see if it works. >>> >> >> Patch fixes the problem on my system. >> > > patch submitted to mailing list. Thanks, and feel free to let me know if > it is proper to add your reported-by, and add your tested-by. > forgot the link. :) https://lore.kernel.org/kvm/20240710004150.319105-1-yi.l.liu@intel.com/T/#u (In reply to Liu, Yi L from comment #6) > patch submitted to mailing list. Thanks, and feel free to let me know if > it is proper to add your reported-by, and add your tested-by. It is ok to add me. Fixed in 6.9.10. Closing this. |