Bug 218706

Summary:	b4 needs-editing check vs single patch serieses
Product:	Tools	Reporter:	Bugspray Bot (bugbot)
Component:	Infra	Assignee:	Konstantin Ryabitsev (konstantin)
Status:	RESOLVED CODE_FIX
Severity:	normal
Priority:	P3
Hardware:	All
OS:	Linux
Kernel Version:		Subsystem:
Regression:	No	Bisected commit-id:

Description Bugspray Bot 2024-04-10 19:20:21 UTC

Mark Brown <broonie@kernel.org> writes:

Hi,

The needs-editing flag in b4 prep --show-info was intended to support
scripting which wraps b4, allowing it to see if b4 would refuse to send.
However as implemented the check does not take account of the logic b4
has which doesn't require a cover letter for a single patch series, it
will just report if EDITME is present in the cover.  Wrappers could do
their own version of the single patch check but it would be good if this
were done in b4.

Thanks,
Mark

(via https://msgid.link/c9a9347a-b795-4824-8edb-9fba31cdfc5d@sirena.org.uk)

Comment 1 Bugspray Bot 2024-04-10 19:20:25 UTC

Konstantin Ryabitsev <konstantin@linuxfoundation.org> writes:

On Mon, Apr 08, 2024 at 07:51:36PM +0100, Mark Brown wrote:
> The needs-editing flag in b4 prep --show-info was intended to support
> scripting which wraps b4, allowing it to see if b4 would refuse to send.
> However as implemented the check does not take account of the logic b4
> has which doesn't require a cover letter for a single patch series, it
> will just report if EDITME is present in the cover.  Wrappers could do
> their own version of the single patch check but it would be good if this
> were done in b4.

bugbot assign to me

-K

(via https://msgid.link/20240410-modest-mini-cuckoo-b6e05a@lemur)

Comment 2 Bugspray Bot 2024-04-18 17:35:23 UTC

Konstantin Ryabitsev writes in commit 11c5cc46b7f4bb10c134e4ba05e984e8ab13ed6f:

ez: improve needs-editing logic for single-patch series

When sending single-patch series, the cover letter does not need to be
edited even if it contains EDITME.

Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218706
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=11c5cc46b7f4)