Bug 217726

(In reply to Guilhem Lettron from comment #0)
> On a kernel 6.4.5 and less, the keyboard is working fine.
> 
> Beginning with 6.5 rc1 and 6.4.7 any key don't respond.
> 
> [    0.668850] input: ASUE140D:00 04F3:31B9 Keyboard as
> /devices/platform/AMDI0010:01/i2c-1/i2c-ASUE140D:00/0018:04F3:31B9.0001/
> input/input5
> ...
> [    1.930328] input: ASUE140D:00 04F3:31B9 Keyboard as
> /devices/platform/AMDI0010:01/i2c-1/i2c-ASUE140D:00/0018:04F3:31B9.0001/
> input/input13

Can you bisect between v6.4.5 and v6.4.7 to find the culprit?

I'd like a few things to further triage this issue.

1) A dmesg from 6.4.5
2) A dmesg from 6.4.7
3) Attempt reverting 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen platforms") to see if it helps.
4) An acpidump
5) If reverting 9946e39fe8d0 does NOT help, then please bisect 6.4.5 to 6.4.7.

Created attachment 304738 [details]
dmesg on 6.4.5

Created attachment 304739 [details]
dmesg on 6.4.7

Created attachment 304740 [details]
acpidump

see: https://bugzilla.kernel.org/show_bug.cgi?id=217718

the fix for this was reverted

(In reply to henil from comment #6)
> see: https://bugzilla.kernel.org/show_bug.cgi?id=217718
> 
> the fix for this was reverted

i meant to link https://bugzilla.kernel.org/show_bug.cgi?id=217718#c0

> [    0.287015] ACPI: IRQ 1 override to edge, high(!)

Yup, so 6.4.7 is showing it's overriding now to edge/high which is causing breakage for you.  You should be able to revert the patch and get success for now.

There is a discussion on the mailing list about the logic is wrong here because it seems like no matter which way we go it's a pile of quirks.

I have the same ASUS laptop and I confirm that reverting a9c4a912b7dc7ff922d4b9261160c001558f9755  (ACPI: resource: Remove "Zen" specific match and quirks) from stable v6.4.7 branch fixes the issue.

I have submitted a revert of a9c4a912b7dc ("ACPI: resource: Remove "Zen" specific match and quirks") upstream now, because I believe that that is the best way to fix the regressions caused by this (until we figure out a better way to deal with the kbd interrupt trigger-type issues):

https://lore.kernel.org/linux-acpi/20230806151453.10690-1-hdegoede@redhat.com/

Thanks @Hans de Goede. Been following this thread for possible fix. To anyone using Arch Linux, my temporary fix was to install and use linux-lts kernel:


sudo pacman -S linut-lts linux-lts-headers;
sudo grub-mkconfig -o /boot/grub/grub.cfg

Can you see if this works?

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 1dd8d5aebf678..b74d7d8cc8630 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -19,7 +19,7 @@
 #include <linux/dmi.h>
 
 #ifdef CONFIG_X86
-#define valid_IRQ(i) (((i) != 0) && ((i) != 2))
+#define valid_IRQ(i) ((i) > 2)
 static inline bool acpi_iospace_resource_valid(struct resource *res)
 {
        /* On X86 IO space is limited to the [0 - 64K] IO port range */

This patch doesn't work, unfortunately.

> This patch doesn't work, unfortunately.

Can you please further describe?  Did your keyboard, mouse or both stop working from a9c4a912b7dc7ff922d4b9261160c001558f9755?

This patch skips creating an IO resource to program to the IOAPIC; but only for the keyboard.  I expect the hardware programmed value would be maintained instead.

So if a9c4a912b7dc7ff922d4b9261160c001558f9755 broke both keyboard and mouse for you this should only "help" keyboard.

And you can see if this patch works for both keyboard and mouse instead.

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index b74d7d8cc8630..6fc8ac1c9e84b 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -19,7 +19,7 @@
 #include <linux/dmi.h>
 
 #ifdef CONFIG_X86
-#define valid_IRQ(i) (((i) != 0) && ((i) != 2))
+#define valid_IRQ(i) (((i) > 2) && && ((i) != 12))
 static inline bool acpi_iospace_resource_valid(struct resource *res)
 {
        /* On X86 IO space is limited to the [0 - 64K] IO port range */

> Can you please further describe?  Did your keyboard, mouse or both stop
> working from a9c4a912b7dc7ff922d4b9261160c001558f9755?

Only keyboard. The laptop's touchpad is working fine.

The test results are this:

* vanilla v6.4.7 branch: keyboard not working, touchpad ok

* vanilla v6.4.7 with https://bugzilla.kernel.org/show_bug.cgi?id=217726#c12 patch: keyboard not working, touchpad ok

* vanilla v6.4.7 with https://bugzilla.kernel.org/show_bug.cgi?id=217726#c15 patch (modified to fix "&& &&" syntax error): keyboard not working, touchpad ok

* vanilla v6.4.7 with a9c4a912b7dc7ff922d4b9261160c001558f9755 reverted: both keyboard and touchpad working

I can check other patches, if you have more ideas.

Thanks.  Hans is proposing a revert of the patch, if I come up with anything else I'll let you know.

linux 6.4.11 contains a fix for this bug, and after updating to 6.4.11 on Arco linux on my UM5302TA, the keyboard is working fine again. Thanks, Hans and Mario!

Link to commit: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.4.11&id=d9dbddc664610ec9ef2ca13518c22960effccec3

6.4.11 works fine for me too. Thanks for the hard work, Hans and Mario!

6.4.11 works for me as well. Thanks for fixing this.

Thanks everyone for reporting the issue as well as for reporting that the issue is fixed now.

Since this is fixed now I'm going to close this bug.