Bug 217383

Summary: Bluetooth: L2CAP: possible data race in __sco_sock_close()
Product: Networking Reporter: Tuo Li (islituo)
Component: OtherAssignee: Stephen Hemminger (stephen)
Status: NEW ---    
Severity: normal CC: islituo
Priority: P3    
Hardware: All   
OS: Linux   
Kernel Version: 6.3.0-rc7 Subsystem:
Regression: No Bisected commit-id:

Description Tuo Li 2023-04-28 10:22:28 UTC
Our static analysis tool finds a possible data race in the l2cap protocol
in Linux 6.3.0-rc7:

In most calling contexts, the variable sk->sk_socket is accessed
with holding the lock sk->sk_callback_lock. Here is an example:

  l2cap_sock_accept() --> Line 346 in net/bluetooth/l2cap_sock.c
      bt_accept_dequeue() --> Line 368 in net/bluetooth/l2cap_sock.c
          sock_graft() --> Line 240 in net/bluetooth/af_bluetooth.c
              write_lock_bh(&sk->sk_callback_lock); --> Line 2081 in include/net/sock.h (Lock sk->sk_callback_lock)
              sk_set_socket() --> Line 2084 in include/net/sock.h
                  sk->sk_socket = sock; --> Line 2054 in include/net/sock.h (Access sk->sk_socket)

However, in the following calling context:
 
  sco_sock_shutdown() --> Line 1227 in net/bluetooth/sco.c
      __sco_sock_close() --> Line 1243 in net/bluetooth/sco.c
          BT_DBG(..., sk->sk_socket); --> Line 431 in net/bluetooth/sco.c (Access sk->sk_socket)

the variable sk->sk_socket is accessed without holding the lock
sk->sk_callback_lock, and thus a data race may occur.

Reported-by: BassCheck <bass@buaa.edu.cn>