Bug 216781

Summary:	wrong check buffer_head in ext4_simulate_fail_bh
Product:	File System	Reporter:	eriri (1527030098)
Component:	ext4	Assignee:	fs_ext4 (fs_ext4)
Status:	RESOLVED INVALID
Severity:	low
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	6.0	Subsystem:
Regression:	No	Bisected commit-id:

Description eriri 2022-12-07 03:06:11 UTC

ext4_simulate_fail_bh used at https://elixir.bootlin.com/linux/latest/source/fs/ext4/inode.c#L4574
but it seems bh(buffer_head) can only be ptr or NULL, so it is wrong to use IS_ERR in ext4_simulate_fail_bh at https://elixir.bootlin.com/linux/latest/source/fs/ext4/ext4.h#L1855

replace IS_ERR with IS_ERR_OR_NULL here.

Comment 1 eriri 2022-12-07 03:12:13 UTC

Oops，it's my mistake.