Bug 216697
| Summary: | Resume from suspend stopped working | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Denis (speranskiy) |
| Component: | USB | Assignee: | Default virtual assignee for Drivers/USB (drivers_usb) |
| Status: | NEW --- | ||
| Severity: | high | CC: | alchernaev, darlor, fancieux, heikki.krogerus, maniette, morten242, oliver, roman.sstu |
| Priority: | P1 | ||
| Hardware: | Intel | ||
| OS: | Linux | ||
| Kernel Version: | 6.0.7 and on | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
| Attachments: |
photo of errors on resume
screenshot of error with patch Test fix |
||
|
Description
Denis
2022-11-17 08:04:28 UTC
Can you blacklist typec_ucsi and ucsi_acpi modules to confirm that it really is a ucsi problem? Yep, blacklisting these modules fix the problem. Hi, I got the similar issue, that I've explained here - https://bbs.archlinux.org/viewtopic.php?id=281375 Blacklisting this module also helps me (In reply to Roman Belikin from comment #3) > Hi, I got the similar issue, that I've explained here - > https://bbs.archlinux.org/viewtopic.php?id=281375 > Blacklisting this module also helps me I think that problem is related to bug 216706 (maybe). I'll figure out a fix for that first. Let's see if it helps with this problem as well. (In reply to Heikki Krogerus from comment #4) > I think that problem is related to bug 216706 (maybe). I'll figure out a fix > for that first. Let's see if it helps with this problem as well. What the status here? was this ever resolved? There is a fix for bug 216706, but it hasn't made it into the mainline nor the stable kernels yet. Can somebody test that fix separately, if it helps with this bug as well? https://bugzilla.kernel.org/attachment.cgi?id=303247 (In reply to Heikki Krogerus from comment #6) > There is a fix for bug 216706, but it hasn't made it into the mainline nor > the stable kernels yet. Can somebody test that fix separately, if it helps > with this bug as well? > https://bugzilla.kernel.org/attachment.cgi?id=303247 Denis, Roman, did you try? Heikki, just btw, there was another issue (bug 216788) where that patch helped. I would love to try, but I'm afraid I'm not experienced enough to build the kernel. Created attachment 303449 [details] screenshot of error with patch Tested with mentioned patch applied to kernel 6.1.0, unfortunately the issue is not resolved. Patch tested: https://bugzilla.kernel.org/attachment.cgi?id=303247 Thanks for checking that. I'll try to figure out what's happening. I also got a similar issue, I've explained here. <https://bbs.archlinux.org/viewtopic.php?pid=2081073>. In https://bugzilla.kernel.org/show_bug.cgi?id=216706, it has been reported that USBC resume callback takes far too long, between 650ms and 1200ms. However, after the same commit mentioned there, my laptop just freezes instead of taking a long time to resume. Noticed you merged a patch in 6.2-rc5, but I just tried 6.2-rc5 and it didn't work. Created attachment 303643 [details]
Test fix
I got a bit more information related to this from Fan Chengwei on the linux-usb ml. I now have here a potential fix for the problem. Can anybody test does it work?
Thanks!
Is this fix suitable for kernel 6.1.x? If yes then I'm willing to test it. (In reply to Oliver Reeh from comment #13) > Is this fix suitable for kernel 6.1.x? > If yes then I'm willing to test it. Great, thanks! The patch should apply just fine on top of 6.1.x. I figured that already ... I'm running a patched kernel 6.1.8 for two days with lots of USB-C/Thunderbolt plugging and unplugging without any issues. No more lockups after suspend and no more kernel oops in the logs. The fix in kernel 6.1.9 doesn't work. 02.02.23 09:59 darkstar kernel RIP: 0010:ucsi_resume_work+0x2e/0x80 [typec_ucsi] The system hangs after resuming from suspend. The patch for this bug has not been applied to any tree yet. That explains it ... I thought commit 3d7f77e55da3455c8844b651e37779c90e201f48 included this fix. No issues with kernel 6.1.9. Yep, can't reproduce with kernel 6.1.9 too. No problems with the patch and kernel 6.1.10 |