Bug 21652

Summary: several problems with intel graphics since 2.6.36
Product: Drivers Reporter: Maciej Rutecki (maciej.rutecki)
Component: Video(DRI - Intel)Assignee: drivers_video-dri-intel (drivers_video-dri-intel)
Status: CLOSED INSUFFICIENT_DATA    
Severity: normal CC: daniel, eddy.petrisor+linbug, florian, maciej.rutecki, mlord, preining, rjw
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 2.6.36 Subsystem:
Regression: Yes Bisected commit-id:
Bug Depends on:    
Bug Blocks: 16444    
Attachments: Screenshot of screen redraw problem

Description Maciej Rutecki 2010-11-01 19:41:46 UTC
Subject    : several problems with intel graphics since 2.6.36
Submitter  : Norbert Preining <preining@logic.at>
Date       : 2010-10-27 14:32
Message-ID : 20101027143252.GA8676@gamma.logic.tuwien.ac.at
References : http://marc.info/?l=linux-kernel&m=128818998630241&w=2

This entry is being used for tracking a regression from 2.6.35. Please don't
close it until the problem is fixed in the mainline.
Comment 1 Mark Lord 2010-11-19 00:52:56 UTC
Looks like perhaps the same issue as reported in this bug:

https://bugzilla.kernel.org/show_bug.cgi?id=21952
Comment 2 Rafael J. Wysocki 2010-11-19 20:30:30 UTC
On Friday, November 19, 2010, Alex Deucher wrote:
> On Thu, Nov 18, 2010 at 7:47 PM, Mark Lord <kernel@teksavvy.com> wrote:
> > On 10-11-18 06:50 PM, Rafael J. Wysocki wrote:
> >>
> >> Bug-Entry       : http://bugzilla.kernel.org/show_bug.cgi?id=21652
> >> Subject         : several problems with intel graphics since 2.6.36
> >> Submitter       : Norbert Preining<preining@logic.at>
> >> Date            : 2010-10-27 14:32 (23 days old)
> >
> > That one is interesting to me.. I suspect it may be the same cause
> > as for https://bugzilla.kernel.org/show_bug.cgi?id=21952
> >
> > I have one of those Samsung (N210) Netbooks here: works fine with 2.6.34
> and
> > earlier,
> > but fails to come out of suspend on 2.6.35/2.6.36 (haven't tried 2.6.37).
> >
> > So perhaps add 21952 to the list, or link it to the 21652
> > (kind of amusing how similar the bug numbers are..).
> >
> >
> > My non-Intel graphics notebook (has ATI X1400 graphics) also has a resume
> > regression with 2.6.36.  But it does work fine with 2.6.35 (and earlier,
> > back many years).  As a result, I'm stuck with 2.6.35 for the time being,
> > and lack the time for a concerted debug effort on 2.6.36+ right now.
> >
> 
> Can you bisect?  Does this patch help?
> 
> diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c
> index 8e421f6..05efb5b 100644
> --- a/drivers/gpu/drm/radeon/atom.c
> +++ b/drivers/gpu/drm/radeon/atom.c
> @@ -112,6 +112,7 @@ static uint32_t atom_iio_execute(struct
> atom_context *ctx, int base,
>                         base += 3;
>                         break;
>                 case ATOM_IIO_WRITE:
> +                       (void)ctx->card->ioreg_read(ctx->card, CU16(base +
> 1));
>                         ctx->card->ioreg_write(ctx->card, CU16(base + 1),
>                         temp);
>                         base += 3;
>                         break;
>
Comment 3 Mark Lord 2010-11-19 21:06:58 UTC
That's better --> it now comes out of suspend, but slowly due to this (2.6.36):

[   98.498636] [drm] radeon: 1 quad pipes, 1 z pipes initialized.
[   98.505748] [drm] PCIE GART of 512M enabled (table at 0x00040000).
[   98.505793] [drm] radeon: ring at 0x0000000008000000
[   98.505827] [drm] ring test succeeded in 10 usecs
[   98.505842] [drm] ib test succeeded in 0 usecs
...
[  103.506664] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 5secs aborting
[  103.506668] [drm:atom_execute_table_locked] *ERROR* atombios stuck executing E576 (len 105, WS 12, PS 8) @ 0xE5C4
[  109.136664] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 5secs aborting
[  109.136667] [drm:atom_execute_table_locked] *ERROR* atombios stuck executing ECD2 (len 86, WS 4, PS 0) @ 0xED05
[  114.139996] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 5secs aborting
[  114.139999] [drm:atom_execute_table_locked] *ERROR* atombios stuck executing E576 (len 105, WS 12, PS 8) @ 0xE5C4
[  114.210130] PM: resume of devices complete after 15718.438 msecs

I've been noticing those same errors from time to time on 2.6.35 as well, but have been trying to ignore them until now.  :)
Comment 4 Norbert Preining 2010-11-22 14:54:52 UTC
Hi there,

yes, some problems remain (in the order of my original email):
- suspend seems to be more stable by now, I am trying to check that

- flickering of the display is definitely much better or completely gone

- screen redraw problem: still present, I attach a screenshot of parts of my
  desktop when it happens. It can easily reproduce that with xpdf.

- external monitor disconnect detection: cannot test at the moment

Thanks and all the best

Norbert
Comment 5 Norbert Preining 2010-11-22 14:55:35 UTC
Created attachment 37862 [details]
Screenshot of screen redraw problem
Comment 6 Norbert Preining 2010-11-23 08:01:01 UTC
Ok, one more comment: suspend is still not working as expected, I had this moment a black screen and no reaction (not even sysrq) while, as reported, this didn't happen (or very very rarely) with earlier versions (see original email).

Norbert
Comment 7 Norbert Preining 2010-12-13 02:47:27 UTC
Updates:
- flickering of display is gone

- screen redraw problem I can still 100% reproduce by starting xpdf (all in Debian/unstable) and move another window *over* the xpdf window. This creates vertical stripes on the xterm I am moving.

- suspend: feeling is that it is slightly better, but still quite often the screen is not turned on and everything hangs, only 4sec hard reset helps.

Norbert
Comment 8 Norbert Preining 2010-12-19 15:01:07 UTC
Following the reminder email I reconfirm my observations from Comment #7
Comment 9 Norbert Preining 2011-01-02 07:27:08 UTC
reconfirmed my observations from comment #7, running rc8
Comment 10 Florian Mickler 2011-03-29 21:50:25 UTC
Whats the status of this on 2.6.38.y? (or 2.6.39-rc*)
Comment 11 Florian Mickler 2011-04-20 20:02:42 UTC
*ping*
Comment 12 Daniel Vetter 2012-03-25 14:25:36 UTC
Bug reporter seems to have disappeared, closing. If this is still an issue on 3.3, please reopen this bug.
Comment 13 Daniel Vetter 2012-03-25 14:26:25 UTC
Also, it's a radeon issue afaict.
Comment 14 Michel Dänzer 2012-03-26 07:58:40 UTC
(In reply to comment #13)
> Also, it's a radeon issue afaict.

AFAICT Norbert's original report was for Intel, Mark's problem was unrelated.
Comment 15 Daniel Vetter 2012-03-26 08:02:38 UTC
Oh dear, sorry I've missed that. Anyway, still closing because the bug reporter seems to have disappeared.
Comment 16 Norbert Preining 2012-03-26 08:22:40 UTC
Agreed, sorry, I missed the ping emails. I am running 3.3 or so and most of these problems are gone, but there is a new one I reported already with details, hangcheck timer elapsed, see http://marc.info/?l=linux-kernel&m=133040184619910&w=2

Closing this bug is fine