Bug 216427

Summary: [bisected] OF fails to handle some PCI resources on a PowerMac G4 3,6 (e.g. OF: /pci@f2000000/mac-io@17/gpio@50/gpio5@6f: could not find phandle 1751474532)
Product: Platform Specific/Hardware Reporter: Erhard F. (erhard_f)
Component: PPC-32Assignee: platform_ppc-32
Status: RESOLVED DUPLICATE    
Severity: normal CC: bugzilla.kernel.org, wsa
Priority: P1    
Hardware: PPC-32   
OS: Linux   
Kernel Version: 6.0-rc3 Subsystem:
Regression: No Bisected commit-id:
Attachments: dmesg (kernel 6.0-rc3, PowerMac G4 DP)
kernel .config (kernel 6.0-rc3, PowerMac G4 DP)
bisect.log

Description Erhard F. 2022-08-29 22:19:26 UTC
Created attachment 301698 [details]
dmesg (kernel 6.0-rc3, PowerMac G4 DP)

This pops up in dmesg on my G4 DP. Perhaps an OF or DT issue?

[...]
Duplicate name in PowerPC,G4@0, renamed to "l2-cache#1"
Duplicate name in l2-cache#1, renamed to "l2-cache#1"
Duplicate name in PowerPC,G4@1, renamed to "l2-cache#1"
Duplicate name in l2-cache#1, renamed to "l2-cache#1"
Duplicate name in gpio@50, renamed to "gpio5@6f#1"
Duplicate name in gpio@50, renamed to "gpio6@70#1"
Duplicate name in gpio@50, renamed to "gpio11@75#1"
Duplicate name in gpio@50, renamed to "extint-gpio15@67#1"
[...]
OF: /pci@f2000000/mac-io@17/gpio@50/gpio5@6f: could not find phandle 1751474532
OF: /pci@f2000000/mac-io@17/gpio@50/extint-gpio15@67: could not find phandle 1751474532
OF: /pci@f2000000/mac-io@17/gpio@50/gpio6@70: could not find phandle 1634562093
OF: /pci@f2000000/mac-io@17/gpio@50/extint-gpio16@68: could not find phandle 1936745825
OF: /pci@f2000000/mac-io@17/gpio@50/extint-gpio14@66: could not find phandle 1818848869
OF: /pci@f2000000/mac-io@17/gpio@50/gpio12@76: could not find phandle 1835103092
OF: /pci@f2000000/mac-io@17/gpio@50/gpio11@75: could not find phandle 1635083369
OF: /pci@f2000000/mac-io@17/gpio@50/gpio5@6f: could not find phandle 1751474532
OF: /pci@f2000000/mac-io@17/gpio@50/gpio6@70: could not find phandle 1634562093
OF: /pci@f2000000/mac-io@17/gpio@50/extint-gpio4@5c: could not find phandle 1818848869
OF: /pci@f2000000/mac-io@17/gpio@50/gpio11@75: could not find phandle 1635083369
OF: /pci@f2000000/mac-io@17/gpio@50/extint-gpio15@67: could not find phandle 1751474532
[...]

Apart from that the machine seems to run fine. More details in the attached dmesg.
Comment 1 Erhard F. 2022-08-29 22:20:03 UTC
Created attachment 301699 [details]
kernel .config (kernel 6.0-rc3, PowerMac G4 DP)
Comment 2 Erhard F. 2022-09-05 10:36:16 UTC
Did a bisect which revealed this as 1st bad commit:

 # git bisect good
c78c31b374a68be79cb4a03ef5b6c187f034e903 is the first bad commit
commit c78c31b374a68be79cb4a03ef5b6c187f034e903
Author: Saravana Kannan <saravanak@google.com>
Date:   Tue Apr 28 12:20:05 2020 -0700

    Revert "Revert "driver core: Set fw_devlink to "permissive" behavior by default""
    
    This reverts commit 18555cb6db2373b9a5ec1f7572773fd58c77f9ba.
    
    The reason[1] for the original revert has now been fixed by
    commit 00b247557858 ("driver core: Fix handling of
    fw_devlink=permissive"). So, this patch reverts the revert. Marek has
    also tested this patch with the fix mentioned above and confirmed that
    the issue has been fixed.
    
    [1] - https://lore.kernel.org/lkml/CAGETcx8nbz-J1gLvoEKE_HgCcVGyV2o8rZeq_USFKM6=s7WmNg@mail.gmail.com/T/#m12dfb5dfd23805b84c49f4bb2238a8cce436c2f7
    [2] - https://lore.kernel.org/lkml/CAGETcx8nbz-J1gLvoEKE_HgCcVGyV2o8rZeq_USFKM6=s7WmNg@mail.gmail.com/T/#m2408a6ce098b2ebf583ca8534329695923ae57fe
    Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
    Signed-off-by: Saravana Kannan <saravanak@google.com>
    Link: https://lore.kernel.org/r/20200428192006.109006-1-saravanak@google.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

 drivers/base/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Erhard F. 2022-09-05 10:37:08 UTC
Created attachment 301744 [details]
bisect.log
Comment 4 Erhard F. 2022-09-12 15:22:06 UTC
Looks like I already reported that one 2 yrs ago...

*** This bug has been marked as a duplicate of bug 208197 ***