Bug 216402

Summary: Dell laptops: hpet_acpi_add: no address or irqs in _CRS
Product: ACPI Reporter: Paul Menzel (pmenzel+bugzilla.kernel.org)
Component: OtherAssignee: acpi_other
Status: NEEDINFO ---    
Severity: normal CC: andrey.vihrov, pmenzel+bugzilla.kernel.org
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 5.18.16 Subsystem:
Regression: No Bisected commit-id:
Attachments: Output of `dmesg`
Output of `acpidump`
Disassembled DSDT
Disassembled DSDT from Dell XPS 13 9360

Description Paul Menzel 2022-08-23 12:53:49 UTC
Created attachment 301635 [details]
Output of `dmesg`

On the Dell XPS 13 9370 with Debian sid/unstable Linux 5.18.16 warns about missing values in _CRS:

    [    0.000000] DMI: Dell Inc. XPS 13 9370/0RMYH9, BIOS 1.21.0 07/06/2022

    [    1.868930] calling  hpet_init+0x0/0x76 @ 1
    [    1.869360] hpet_acpi_add: no address or irqs in _CRS
    [    1.869812] initcall hpet_init+0x0/0x76 returned 0 after 876
Comment 1 Paul Menzel 2022-08-23 12:59:07 UTC
Created attachment 301636 [details]
Output of `acpidump`
Comment 2 Paul Menzel 2022-08-23 13:05:38 UTC
Created attachment 301637 [details]
Disassembled DSDT
Comment 3 Artem S. Tashkinov 2022-08-23 13:15:39 UTC
This warning is quite common. Do you have any issues?

https://www.google.com/search?q=%22hpet_acpi_add:+no+address+or+irqs+in+_CRS%22&tbs=qdr:y&sa=X
Comment 4 Paul Menzel 2022-08-23 13:34:33 UTC
I have only used the device again for some days, so no idea, if there are user facing issues.

    $ cat /sys/devices/system/clocksource/clocksource0/available_clocksource 
    tsc acpi_pm
    $ cat /sys/devices/system/clocksource/clocksource0/current_clocksource
    tsc

If it’s not going to cause issues, then the log level should be reduced, and maybe also more background on the effects given to the user.
Comment 5 Paul Menzel 2023-02-27 13:37:15 UTC
This warning is also logged on the Dell Precision 3540 with the latest firmware 1.23.0:

    [    0.819881] hpet_acpi_add: no address or irqs in _CRS
Comment 6 Paul Menzel 2023-03-01 13:03:52 UTC
It seems to be a more general problem. Linux warns about this also on a Supermicro Super Server/X13SAE.

```
$ dmesg | grep -e "Linux version" -e DMI:
[    0.000000] Linux version 5.15.94.mx64.447 (root@theinternet.molgen.mpg.de) (gcc (GCC) 10.4.0, GNU ld (GNU Binutils) 2.37) #1 SMP Sun Feb 19 18:42:34 CET 2023
[    0.000000] DMI: Supermicro Super Server/X13SAE, BIOS 2.0 10/17/2022
$ dmesg --level=warn
[    2.051956] ENERGY_PERF_BIAS: Set to 'normal', was 'performance'
[    3.769316] pnp 00:04: disabling [mem 0xc0000000-0xcfffffff] because it overlaps 0000:00:02.0 BAR 9 [mem 0x00000000-0xdfffffff 64bit pref]
[    5.074722] hpet_acpi_add: no address or irqs in _CRS
[    5.824016] acpi PNP0C14:01: duplicate WMI GUID 05901221-D566-11D1-B2F0-00A0C9062910 (first instance was on PNP0C14:00)
```
Comment 7 Paul Menzel 2024-03-04 10:01:01 UTC
Created attachment 305956 [details]
Disassembled DSDT from Dell XPS 13 9360

On the older Dell XPS 13 9360, the warning is also present.

```
        Device (HPET)
        {
            Name (_HID, EisaId ("PNP0103") /* HPET System Timer */)  // _HID: Hardware ID
            Name (_UID, Zero)  // _UID: Unique ID
            Name (BUF0, ResourceTemplate ()
            {
                Memory32Fixed (ReadWrite,
                    0xFED00000,         // Address Base
                    0x00000400,         // Address Length
                    _Y32)
            })
            Method (_STA, 0, NotSerialized)  // _STA: Status
            {
                If (HPTE)
                {
                    Return (0x0F)
                }

                Return (Zero)
            }

            Method (_CRS, 0, Serialized)  // _CRS: Current Resource Settings
            {
                If (HPTE)
                {
                    CreateDWordField (BUF0, \_SB.PCI0.LPCB.HPET._Y32._BAS, HPT0)  // _BAS: Base Address
                    HPT0 = HPTB /* \HPTB */
                }

                Return (BUF0) /* \_SB_.PCI0.LPCB.HPET.BUF0 */
            }
        }
```