Bug 216352
Summary: | [BISECTED] 250 ms system suspend performance regression | ||
---|---|---|---|
Product: | Drivers | Reporter: | Len Brown (lenb) |
Component: | Bluetooth | Assignee: | linux-bluetooth (linux-bluetooth) |
Status: | NEW --- | ||
Severity: | normal | CC: | abhishekpandit, lenb, luiz.dentz, rjw, todd.e.brandt |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 5.19 | Subsystem: | |
Regression: | Yes | Bisected commit-id: | |
Attachments: |
sleepgraph 5.19-rc8: 411ms suspend
sleepgraph 5.19.0: 686 ms suspend Bluetooth: hci_sync: Fix suspend performance regression |
Description
Len Brown
2022-08-11 00:47:45 UTC
Created attachment 301548 [details]
sleepgraph 5.19-rc8: 411ms suspend
Created attachment 301549 [details]
sleepgraph 5.19.0: 686 ms suspend
Comparing the attached sleepgraph output of 5.19 to 5.19-rc8... acpi_ps_execute_method(PCI.XHC._PS0) plus msleep 120 msleep 40 msleep 40 msleep 10 have, as a group, shifted left from the suspend phase, where they used to overlap with other tasks, into the suspend_prepare phase, where they are the slowest operation. (In reply to Len Brown from comment #3) > Comparing the attached sleepgraph output of 5.19 to 5.19-rc8... > > acpi_ps_execute_method(PCI.XHC._PS0) plus > msleep 120 > msleep 40 > msleep 40 > msleep 10 > > have, as a group, shifted left from the suspend phase, > where they used to overlap with other tasks, > into the suspend_prepare phase, where they are the > slowest operation. We can probably return to the way it was if we detect the event mask needs updating or not by checking if there is any connections, anyway if you attempt to suspend while there is a bluetooth connection this extra latency would probably reappear since in that case we need to update the event mask in order to not wakeup the system by events such Disconnect Complete, not sure if this is acceptable or perhaps the root cause is that notifiers are serialized so while these commands are pending it prevents other notifiers to be run? Created attachment 301553 [details]
Bluetooth: hci_sync: Fix suspend performance regression
@Len Brown any chance to test with the above patch? |