Bug 216267

Summary: acp6x: Incorrect product IDs for some AMD ThinkPads
Product: Drivers Reporter: David Korth (gerbilsoft)
Component: Sound(ALSA)Assignee: Jaroslav Kysela (perex)
Status: RESOLVED CODE_FIX    
Severity: normal CC: dober, iam, mario.limonciello, mpearson-lenovo, tiwai, Vijendar.Mukunda
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 5.19 (git master) Subsystem:
Regression: No Bisected commit-id:

Description David Korth 2022-07-21 18:55:52 UTC 
acp6x-mach.c has a hard-coded list of quirks for ThinkPads with AMD Ryzen 6000 series CPUs. Some of these product IDs don't seem to be correct.

The full list:
* 21D2/21D3 (Z13 Gen 1)
* 21D4/21D5 (Z16 Gen 1)
* 21CF/21CG (T14 Gen 3)
* 21CQ/21CR (T14s Gen 3)
* 21AW/21AX (X13 Yoga Gen 3 [Intel])
* 21BN/21BQ (X13 Gen 3 [Intel])
* 21CH/21CJ (T16 Gen 1)
* 21CK/21CL (P16s Gen 1)
* 21D8/21D9 (P15v Gen 3)

Of these, the X13 Yoga Gen 3 is an Intel-only system, and the X13 Gen 3 listed here is the Intel version. Presumably the X13 Yoga Gen 3 should be removed, and the X13 Gen 3 should be updated with the product codes for the AMD version: 21CM/21CN.
Comment 1 David Korth 2022-07-21 19:06:06 UTC 
Minor update: 21D8/21D9 is P15v Gen 3 (Intel); there doesn't appear to be an AMD version. This should be removed as well.
Comment 2 Mario Limonciello (AMD) 2022-07-22 12:13:47 UTC 
Yes it seems that the initial list of IDs provided had some mistakes.

> and the X13 Gen 3 should be updated with the product codes for the AMD
> version: 21CM/21CN

I believe we need to confirm that omission uses a DMIC before adding this to the list.
Comment 3 David Korth 2022-07-22 13:15:08 UTC 
The T14s Gen 3 and X13 Gen 3 both use the same system board, so I'd think the X13 would have DMIC if the T14s does.
Comment 4 Mario Limonciello (AMD) 2022-07-22 14:45:17 UTC 
Yeah T14s does, so X13 is an oversight it looks like.  Thanks!
Comment 6 David Ober 2022-07-26 13:41:30 UTC 
In reference to Comment 1 the P15v AMD IDs are 21EM and 21EN
Comment 7 Mario Limonciello (AMD) 2022-07-26 13:43:44 UTC 
@David,

For P15v can you add acp6x _DSD instead to BIOS?
Comment 8 David Ober 2022-07-26 13:56:34 UTC 
Also of note the P14s gen 3 recently added is not on the list ids are 21J5 and 21J6
Comment 9 Sebastian S. 2022-09-20 16:43:13 UTC 
Product ID "82" (Lenovo Slim 7 Pro X) can also be added to the quirks list, see https://bugzilla.kernel.org/show_bug.cgi?id=216299#c3