Bug 216189
Summary: | amd-pstate stops working after S3 suspend | ||
---|---|---|---|
Product: | Power Management | Reporter: | a |
Component: | cpufreq | Assignee: | linux-pm (linux-pm) |
Status: | RESOLVED DUPLICATE | ||
Severity: | normal | CC: | perry_yuan, sujinzhou2008 |
Priority: | P1 | ||
Hardware: | AMD | ||
OS: | Linux | ||
Kernel Version: | 5.18.8 | Subsystem: | |
Regression: | No | Bisected commit-id: |
Description
a
2022-06-29 15:21:36 UTC
May be duplicate of https://bugzilla.kernel.org/show_bug.cgi?id=215938 *** This bug has been marked as a duplicate of bug 215938 *** Hello, The fixed patch has been accepted. It will be updated in 5.19. Here is the detail On Thu, Jun 23, 2022 at 9:53 AM Huang Rui <ray.huang@amd.com> wrote: > > On Thu, Jun 23, 2022 at 11:15:09AM +0800, Su, Jinzhou (Joe) wrote: > > When system resumes from S3, the CPPC enable register will be > > cleared and reset to 0. So sets this bit to enable CPPC interface by > > writing 1 to this register. > > > > Signed-off-by: Jinzhou Su <Jinzhou.Su@amd.com> > > Signed-off-by: Jinzhou Su <Jinzhou.Su@amd.com> > Cc: stable@vger.kernel.org > > You can add one line below your commit description to Cc stable > mailing list. And next time in V2, it's better to use subject-prefix > optional to mark it as v2 like below: > > git format-patch --subject-prefix="PATCH v2" HEAD~ > > Other looks good for me, patch is > > Acked-by: Huang Rui <ray.huang@amd.com> > > > --- > > drivers/cpufreq/amd-pstate.c | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/drivers/cpufreq/amd-pstate.c > > b/drivers/cpufreq/amd-pstate.c index 7be38bc6a673..9ac75c1cde9c > > 100644 > > --- a/drivers/cpufreq/amd-pstate.c > > +++ b/drivers/cpufreq/amd-pstate.c > > @@ -566,6 +566,28 @@ static int amd_pstate_cpu_exit(struct cpufreq_policy > *policy) > > return 0; > > } > > > > +static int amd_pstate_cpu_resume(struct cpufreq_policy *policy) { > > + int ret; > > + > > + ret = amd_pstate_enable(true); > > + if (ret) > > + pr_err("failed to enable amd-pstate during resume, > > + return %d\n", ret); > > + > > + return ret; > > +} > > + > > +static int amd_pstate_cpu_suspend(struct cpufreq_policy *policy) { > > + int ret; > > + > > + ret = amd_pstate_enable(false); > > + if (ret) > > + pr_err("failed to disable amd-pstate during suspend, > > + return %d\n", ret); > > + > > + return ret; > > +} > > + > > /* Sysfs attributes */ > > > > /* > > @@ -636,6 +658,8 @@ static struct cpufreq_driver amd_pstate_driver = { > > .target = amd_pstate_target, > > .init = amd_pstate_cpu_init, > > .exit = amd_pstate_cpu_exit, > > + .suspend = amd_pstate_cpu_suspend, > > + .resume = amd_pstate_cpu_resume, > > .set_boost = amd_pstate_set_boost, > > .name = "amd-pstate", > > .attr = amd_pstate_attr, > > -- Applied with some edits in the subject and changelog, and a CC:stable tag added, as 5.19-rc material. Thanks! Hello, It works on my local. Please try the update and close the issue. Thanks! Joe |