Bug 215983
| Summary: | Whitelist Dell G5 5590 (or more broadly the entire G Series family) on dell_smm_hwmon | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Mateus Rodrigues Costa (mateusrodcosta) |
| Component: | Hardware Monitoring | Assignee: | Jean Delvare (jdelvare) |
| Status: | NEW --- | ||
| Severity: | enhancement | CC: | W_Armin |
| Priority: | P1 | ||
| Hardware: | Intel | ||
| OS: | Linux | ||
| Kernel Version: | 5.17.6-300.fc36.x86_64 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
|
Description
Mateus Rodrigues Costa
2022-05-16 11:01:37 UTC
Just two questions: - does the dell_smm_hwmon kernel module load without force=1? - does loading the dell_smm_hwmon kernel module cause any issues (suspend, fn keys, audio stutter, lags, etc)? If you can confidently answer both questions with no, when i will be happy to write a patch which whitelists your notebook model. However the entire G-Series will likely only be whitelisted if more working models are found. Besides that, if you can disable automatic fan control (i assume with dell-bios-fan-control) without causing any problems (see the second question), then i could additionally add your model on the fan mode control whitelist. (In reply to Armin Wolf from comment #1) > - does the dell_smm_hwmon kernel module load without force=1? I believe that yes. I personally only load the dell-smm-hwmon module and use the ignore dmi option and it works fine. Like this: ``` [mateusrc@centauro ~]$ cat /etc/modules-load.d/dell-smm-hwmon.conf dell-smm-hwmon ``` ``` [mateusrc@centauro ~]$ cat /etc/modprobe.d/dell-smm-hwmon.conf options dell-smm-hwmon ignore_dmi=1 ``` > - does loading the dell_smm_hwmon kernel module cause any issues > (suspend, fn keys, audio stutter, lags, etc)? As far as I noticed, no. At least nothing that I could pinpoint as exactly the fault of the dell_smm_hwmon modules instead of any other component of my system. All of those listed seem to work fine. As a reminder I only care about this module to be able to see the current fan speed, as there is no other way to do it. > If you can confidently answer both questions with no, when i will be > happy to write a patch which whitelists your notebook model. Makes sense, IMHO it could be whitelisted with no problems. > However the entire G-Series will likely only be whitelisted if > more working models are found. Also makes a lot of sense, although I believe there are several places that users post that their Dell (and also Alienware, I think) laptops should be compatible with dell_smm_hwmon (but tutorials for that usually tell to use "force" instead of "ignore_dmi"), just nothing "unified". But I believe nobody tries to report to kernel bugzilla to actually fix it. > Besides that, if you can disable automatic fan control (i assume > with dell-bios-fan-control) without causing any problems (see the > second question), then i could additionally add your model on the > fan mode control whitelist. IIRC, dell-bios-fan-control works fine here, I have used it a few times before, but since I never really figured out how to manually control fans, and didn't want to risk misconfiguration damaging the laptop, then I never stuck with that and still use bios automatic fan control. I can check it at some future point in time though, but at the moment I can't guarantee much. (In reply to Mateus Rodrigues Costa from comment #2) > (In reply to Armin Wolf from comment #1) > > > - does the dell_smm_hwmon kernel module load without force=1? > > I believe that yes. > > I personally only load the dell-smm-hwmon module and use the ignore dmi > option and it works fine. Like this: > > ``` > [mateusrc@centauro ~]$ cat /etc/modules-load.d/dell-smm-hwmon.conf > dell-smm-hwmon > ``` > > ``` > [mateusrc@centauro ~]$ cat /etc/modprobe.d/dell-smm-hwmon.conf > options dell-smm-hwmon ignore_dmi=1 > ``` > > > - does loading the dell_smm_hwmon kernel module cause any issues > > (suspend, fn keys, audio stutter, lags, etc)? > > As far as I noticed, no. > At least nothing that I could pinpoint as exactly the fault of the > dell_smm_hwmon modules instead of any other component of my system. > All of those listed seem to work fine. > > As a reminder I only care about this module to be able to see the current > fan speed, as there is no other way to do it. > > > If you can confidently answer both questions with no, when i will be > > happy to write a patch which whitelists your notebook model. > > Makes sense, IMHO it could be whitelisted with no problems. > Ok, i will write the patch soon. > > However the entire G-Series will likely only be whitelisted if > > more working models are found. > > Also makes a lot of sense, although I believe there are several places that > users post that their Dell (and also Alienware, I think) laptops should be > compatible with dell_smm_hwmon (but tutorials for that usually tell to use > "force" instead of "ignore_dmi"), just nothing "unified". But I believe > nobody tries to report to kernel bugzilla to actually fix it. > > > Besides that, if you can disable automatic fan control (i assume > > with dell-bios-fan-control) without causing any problems (see the > > second question), then i could additionally add your model on the > > fan mode control whitelist. > > IIRC, dell-bios-fan-control works fine here, I have used it a few times > before, but since I never really figured out how to manually control fans, > and didn't want to risk misconfiguration damaging the laptop, then I never > stuck with that and still use bios automatic fan control. > > I can check it at some future point in time though, but at the moment I > can't guarantee much. No problem. Your model is now whitelisted, the patch is currently in hwmon-next and will likely arrive with kernel 5.20. |