Bug 215848
Summary: | fopen(3): Incorrect good practice suggestion | ||
---|---|---|---|
Product: | Documentation | Reporter: | Avinash Sonawane (rootkea) |
Component: | man-pages | Assignee: | documentation_man-pages (documentation_man-pages) |
Status: | RESOLVED CODE_FIX | ||
Severity: | normal | CC: | alx |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | Subsystem: | ||
Regression: | No | Bisected commit-id: |
Description
Avinash Sonawane
2022-04-17 17:05:16 UTC
I think we should only mention using `fseek` as a good practice between read and write operations since: a. fflush can't be used on input stream i.e. if last operation was read while fseek() can be used between read-write or write-read. b. fsetpos needs fgetpos to be called first. So let's drop `fgetpos+fsetpos` from the good practice suggestion So I suggest this small change: diff --git a/man3/fopen.3 b/man3/fopen.3 index a1d781706..fb289a537 100644 --- a/man3/fopen.3 +++ b/man3/fopen.3 @@ -138,8 +138,6 @@ result of writes other than the most recent.) Therefore it is good practice (and indeed sometimes necessary under Linux) to put an .BR fseek (3) -or -.BR fgetpos (3) operation between write and read operations on such a stream. This operation may be an apparent no-op (as in \fIfseek(..., 0L, SEEK_CUR)\fP Thanks! Hi Avinash, I decided to keep fsetpos(3) to not lose the info, so I applied the following patch: fopen.3: tfix Reported-by: Avinash Sonawane <rootkea@gmail.com> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> diff --git a/man3/fopen.3 b/man3/fopen.3 index b9bbc4704..465031167 100644 --- a/man3/fopen.3 +++ b/man3/fopen.3 @@ -114,7 +114,7 @@ Therefore it is good practice (and indeed sometimes necessary under Linux) to put an .BR fseek (3) or -.BR fgetpos (3) +.BR fsetpos (3) operation between write and read operations on such a stream. This operation may be an apparent no-op (as in \fIfseek(..., 0L, SEEK_CUR)\fP |