Bug 215743

Summary: 5.16.14 built on Centos6 with make binrpm-pkg, but 5.16.17 fails with identical configure
Product: Other Reporter: Robert Dinse (nanook)
Component: OtherAssignee: other_other
Status: CLOSED CODE_FIX    
Severity: normal CC: regressions
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 5.16.17 Subsystem:
Regression: No Bisected commit-id:
Attachments: The .config tried to build against, did a make mrproper first.

Description Robert Dinse 2022-03-25 08:59:18 UTC
Created attachment 300616 [details]
The .config tried to build against, did a make mrproper first.

Under Centos6 5.16.14 built successfully but 5.16.17 fails with the same .config.

  HOSTCC  scripts/mod/sumversion.o
parse-options.c: In function ‘get_value’:
parse-options.c:103:28: error: this statement may fall through [-Werror=implicit-fallthrough=]
  103 |                         if (!(opt->flags & PARSE_OPT_NOARG))
      |                            ^
parse-options.c:106:17: note: here
  106 |                 case OPTION_BOOLEAN:
      |                 ^~~~
parse-options.c: In function ‘print_option_help’:
parse-options.c:740:20: error: this statement may fall through [-Werror=implicit-fallthrough=]
  740 |                 if (opts->flags & PARSE_OPT_NOARG)
      |                    ^
parse-options.c:743:9: note: here
  743 |         case OPTION_STRING:
      |         ^~~~
cc1: all warnings being treated as errors
make[7]: *** [/usr/src/linux-5.16.17/tools/objtool/parse-options.o] Error 1
make[6]: *** [/usr/src/linux-5.16.17/tools/objtool/libsubcmd-in.o] Error 2
make[5]: *** [/usr/src/linux-5.16.17/tools/objtool/libsubcmd.a] Error 2
make[5]: *** Waiting for unfinished jobs....
  CC      /usr/src/linux-5.16.17/tools/objtool/objtool.o
  CC      /usr/src/linux-5.16.17/tools/objtool/libstring.o
  CC      /usr/src/linux-5.16.17/tools/objtool/libctype.o
  LD      /usr/src/linux-5.16.17/tools/objtool/arch/x86/objtool-in.o
  CC      /usr/src/linux-5.16.17/tools/objtool/str_error_r.o
  CC      /usr/src/linux-5.16.17/tools/objtool/librbtree.o
  UPD     scripts/mod/devicetable-offsets.h
  HOSTCC  scripts/mod/file2alias.o
  HOSTLD  scripts/mod/modpost
  CC      kernel/bounds.s
  CALL    scripts/atomic/check-atomics.sh
  LD      /usr/src/linux-5.16.17/tools/objtool/objtool-in.o
make[4]: *** [objtool] Error 2
make[3]: *** [tools/objtool] Error 2
make[3]: *** Waiting for unfinished jobs....
  UPD     include/generated/bounds.h
  UPD     include/generated/timeconst.h
  CC      arch/x86/kernel/asm-offsets.s
  UPD     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
make[2]: *** [binrpm-pkg] Error 2
make[1]: *** [binrpm-pkg] Error 2
make: *** [__sub-make] Error 2
Comment 1 Artem S. Tashkinov 2022-03-25 09:52:52 UTC
Make sure you've downloaded clean sources and working only with them.

Linux kernel 5.15+ requires at the very least GCC 5.1 which CentOS 6 doesn't supply.

https://www.phoronix.com/scan.php?page=news_item&px=Linux-5.15-Raising-GCC
Comment 2 Robert Dinse 2022-03-26 22:21:09 UTC
I downloaded source for both 5.16.14 and 5.16.17 directly from kernel.org.

I built gcc 11.2 on Centos6 and that is what I used to compile these kernels.

Kernel 5.16.14 compiled successfully and is running.

Kernel 5.16.17 failed to compile with the above error using exactly the same
configuration and compiler.

As you can see it is a warning but since -WALL is used in the GCC make files,
it results in failure.
Comment 3 Robert Dinse 2022-03-26 22:21:53 UTC
I said gcc make files, meant kernel make files.
Comment 4 The Linux kernel's regression tracker (Thorsten Leemhuis) 2022-04-01 10:57:21 UTC
I'm not involved at all in this area, but bisecting the change that causes this would help a lot here.
Comment 5 Robert Dinse 2022-04-02 00:29:17 UTC
Whatever the issue in 5.16.17 was, it is fixed in 5.16.18, I just successfully compiled a kernel for Centos6 with 5.16.18 where 5.16.17 failed, again same configuration.  Therefore I suggest closing this bug.
Comment 6 Robert Dinse 2022-08-26 08:11:22 UTC
Since 5.16 is past end of life, and 5.19 doesn't have this problem and even later in 5.16.18 it was gone, there is no reason to keep this ticket open.