Bug 215730
Summary: | acpi_bus_register_driver() does not work on Alder Lake | ||
---|---|---|---|
Product: | Drivers | Reporter: | xuemin (xuemin.wu) |
Component: | Platform_x86 | Assignee: | drivers_platform_x86 (drivers_platform_x86) |
Status: | RESOLVED CODE_FIX | ||
Severity: | high | CC: | mjg59-kernel |
Priority: | P1 | ||
Hardware: | x86-64 | ||
OS: | Linux | ||
Kernel Version: | 5.13, 5.16, maybe all. | Subsystem: | |
Regression: | No | Bisected commit-id: | |
Attachments: |
acpidump.output.txt
acpidump.output.txt--after-updated-latest-BIOS |
Description
xuemin
2022-03-23 03:28:30 UTC
Can you attach the output of acpidump? It's unlikely that this is down to the CPU, but more likely that the device ID has changed. Created attachment 300602 [details]
acpidump.output.txt
(In reply to Matthew Garrett from comment #1) > Can you attach the output of acpidump? It's unlikely that this is down to > the CPU, but more likely that the device ID has changed. Hi Garrett, Thank you for the infomation. Please see the attached file above. Yes, no devices supported by toshiba_acpi are present in your ACPI tables, so this is expected. Any functionality that toshiba_acpi has is probably implemented via WMI instead on this device. Created attachment 300608 [details]
acpidump.output.txt--after-updated-latest-BIOS
Hi Garrett Thank you. Which ACPI table related? which device id? Would you tell some details about it? I checked the device on Windows, seems the functions are working without problems. (Windows uses the same ACPI tables/interfaces from BIOS too) I have updated the latest BIOS for the device. but no luck to the problem. I attached again the new acpidump out after updating the latest BIOS. Would your check if still the same issue ( devices id related?) acpi_bus_register_driver passes a set of supported ACPI device IDs to the kernel. In the case of toshiba_acpi, it's: {"TOS6200", 0}, {"TOS6207", 0}, {"TOS6208", 0}, {"TOS1900", 0}, If your firmware exposes any of these devices then the add method will be called. Your firmware doesn't expose any of them, and so it isn't. The driver simply doesn't support your hardware. What functionality on your system is not working? All functions which depending on toshiba_acpi are not working. static struct acpi_driver toshiba_acpi_driver = { .name = "Toshiba ACPI driver", .owner = THIS_MODULE, .ids = toshiba_device_ids, .flags = ACPI_DRIVER_ALL_NOTIFY_EVENTS, .ops = { .add = toshiba_acpi_add, // ===> here .remove = toshiba_acpi_remove, .notify = toshiba_acpi_notify, }, .drv.pm = &toshiba_acpi_pm, }; the toshiba_acpi_add(...){ ...} not be excuted on that device. Thanks. Your laptop does not implement the ACPI interfaces that this driver needs. Hi Garrett Thank you very much for your advise. I confirmed with the BIOS team of the laptop. A new device Id has been added from Alder Lake platfrom: { "DNBK0001",0} I added above device Id and the toshiba_acpi driver works on the laptop. Thank you. Best regards. *** Bug 215724 has been marked as a duplicate of this bug. *** |