Bug 215484
| Summary: | Headphone output gets unproperly powered down - Mi Notebook Pro 2020 (ALC256) | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Emanuele Melzi (itsbytebites) |
| Component: | Sound(ALSA) | Assignee: | Jaroslav Kysela (perex) |
| Status: | NEW --- | ||
| Severity: | normal | CC: | kai.heng.feng, kailang, regressions, tiwai |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 5.16.0 | Subsystem: | |
| Regression: | Yes | Bisected commit-id: | |
| Attachments: |
alsa-info output with headphones connected
bisect.log for the faulty commit proposed fix patch v2 |
||
|
Description
Emanuele Melzi
2022-01-11 20:16:11 UTC
Could you try bisect? I have tried bisect, and the bad commit seems to be this: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/sound/pci/hda/patch_realtek.c?id=f8d3c17e1c3720a1497b5c5db514a832834610d1 Attaching bisect.log Created attachment 300267 [details]
bisect.log for the faulty commit
Thanks! I suppose that the function is recovered when you revert the commit? If yes, which part plays the role? -- there are two chunks in the patch, the first one is about alc_shutup_pins() and another alc256_shutup(). Yes, I have just tried compiling 5.16 deleting manually only the second part of the patch, and that did it! The first part is not a problem. I just deleted the spec->codec_variant != ALC269_TYPE_ALC256 line on the if. Thanks for quick testing. Kailang, Kai-Heng, could you guys check this regression? It seems that the COEF 0x46 change is still required on some ALC256 devices. But set this COEF 0x46, It will lose headset Mic on booted with plugged Headset on some machine. This was Hui Wang patched. It will show this symptom on runtime suspend. I tested on the originally affected machine which equips ALC236, reverting the patch and adding "codec->core.vendor_id != 0x10ec0236" and MIC recording still works fine. Kailiang, do you think that also works for you? I think it would be reverted the patch. Then if the platform with lose headset Mic, Please add the quirk with function alc_combo_jack_hp_jd_restart(); Created attachment 300285 [details]
proposed fix
Kailiang, With the patch applied, the originally affected system can still detect headset MIC. Can you please elaborate what you meant on "lose headset MIC"? Hi Kai Heng, Some platforms meet set COEF 0x46 will lose headset Mic on Booted with plugged Headset. If it had this symptom, please add a quirk with the function will fix it. Commit "ALSA: hda/realtek - ALC236 headset MIC recording issue" solved an issue that first few seconds of recording is missing. So if we change it to 'vendor_id != 0x10ec0257 && vendor_id != 0x10ec0236', the commit can still solve the issue for me and also fix the regression for this bug. IIUC what you meant is that my proposed patch may introduce another kind of regression, which can be fixed by using alc_combo_jack_hp_jd_restart()? What's the status here? Was the issue resolved or did it fall through the cracks? (In reply to The Linux kernel's regression tracker (Thorsten Leemhuis) from comment #14) > > What's the status here? Was the issue resolved or did it fall through the > cracks? That was four week ago, no answer from the developers. That's not how regressions should be handled. :-/ Or was the problem fixed meanwhile? Emanuele, is this problem still present in 5.15.y or 5.16.y? Yes, I am currently on 5.16.12 and the problem is still present (In reply to Emanuele Melzi from comment #16) > Yes, I am currently on 5.16.12 and the problem is still present Can you please give the diff in comment #10 a try? Thanks! I just tried the patch on comment 10 on 5.17 and it works! Created attachment 300636 [details]
patch v2
I made a stupid mistake in the patch, please test v2 patch here, thanks!
v2 patch works too! |