Bug 214343

Summary: Intel 9560 crashes immediately on iwl_mvm_ppag_init()
Product: Drivers Reporter: Kai-Heng Feng (kai.heng.feng)
Component: network-wireless-intelAssignee: Default virtual assignee for network-wireless-intel (drivers_network-wireless-intel)
Status: REOPENED ---    
Severity: normal CC: luca, miriam.rachel.korenblit
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: mainline, wireless-drivers-next Subsystem:
Regression: No Bisected commit-id:
Attachments: dmesg with iwlwifi.debug=0x80
dmesg with iwlwifi.debug=0x80, iwl_mvm_ppag_init() commented out
dmesg with the proposed fix
dmesg iwlwifi.debug=0x80

Description Kai-Heng Feng 2021-09-07 11:27:07 UTC
Commit 551d793f65364c904921ac168d4b4028bb51be69 ("iwlwifi: mvm: store PPAG enabled/disabled flag properly") crashes Intel 9560 immediately on iwl_mvm_ppag_init().

If the iwl_mvm_ppag_init() is commented out in iwl_mvm_up() then the WiFi works.

The laptop is an HP so PPAG is enabled.

Same issue can be observed with wireless-drivers-next and iwlwifi/linux-firmware.
Comment 1 Kai-Heng Feng 2021-09-07 11:27:55 UTC
Created attachment 298699 [details]
dmesg with iwlwifi.debug=0x80
Comment 2 Kai-Heng Feng 2021-09-07 11:28:40 UTC
Created attachment 298701 [details]
dmesg with iwlwifi.debug=0x80, iwl_mvm_ppag_init() commented out
Comment 3 Luca Coelho 2021-09-07 12:05:41 UTC
Thanks for your report!

The commit that broke iwlwifi on your system just enables the PPAG command to the firmware and I can see from the logs that the FW is rejecting the command we're sending to it as being a bad command.  This could mean that we're trying to send the incorrect version or that the command size is wrong.

I'm checking this specific FW version and the driver to see what is causing this incompatibility.
Comment 4 Kai-Heng Feng 2021-09-17 05:40:16 UTC
Luca, is there any progress on this issue?
Comment 5 Luca Coelho 2021-09-23 11:45:45 UTC
Sorry, Kai-Heng, this issue was assigned to someone else in our team and she's currently on vacation/holidays.  So it will take some time for us to have some news for you.
Comment 6 Kai-Heng Feng 2021-09-23 14:20:25 UTC
Thanks for the update.
Comment 7 Kai-Heng Feng 2021-10-29 02:15:57 UTC
I was told that PPAG is not supported? If that's the case, can we remove "HP" from the PPAG whitelist?
Comment 8 Kai-Heng Feng 2021-12-16 05:16:31 UTC
Any progress? Or I intend to write a quirk to disable PPAG based on subsystem device ID:
00:14.3 Network controller [0280]: Intel Corporation Device [8086:a0f0] (rev 20)
        Subsystem: Intel Corporation Device [8086:0034]
Comment 9 Luca Coelho 2021-12-19 10:23:17 UTC
Here's the patch that should fix the issue:

https://patchwork.kernel.org/project/linux-wireless/patch/iwlwifi.20211219121514.793a509da7bd.Ia176746a28b816b5f788cce9a281139735909e2a@changeid/

It should get into v5.17.
Comment 10 Kai-Heng Feng 2021-12-21 05:52:50 UTC
Unfortunately it doesn't fix the issue.
Comment 11 Kai-Heng Feng 2021-12-21 05:53:58 UTC
Created attachment 300101 [details]
dmesg with the proposed fix
Comment 12 Kai-Heng Feng 2021-12-21 05:55:22 UTC
FWIW, tested on wireless-drivers-next tree with the full series applied.
Comment 13 Miri Korenblit 2022-04-03 20:13:37 UTC
Hi,

Could you provide the dmesg with iwlwifi.debug=0x80?
Comment 14 Kai-Heng Feng 2022-04-08 13:39:43 UTC
Created attachment 300725 [details]
dmesg iwlwifi.debug=0x80

Issue can still be observed on next-20220407.