Bug 214085

Summary: Integrate downstream patches
Product: Tools Reporter: Andrew G. Morgan (morgan)
Component: libcapAssignee: Andrew G. Morgan (morgan)
Status: RESOLVED CODE_FIX    
Severity: enhancement    
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: n/a Subsystem:
Regression: No Bisected commit-id:

Description Andrew G. Morgan 2021-08-17 03:30:00 UTC 
Take a look at the way various distributions package libcap and upstream anything that makes sense.

https://sources.debian.org/patches/libcap2/1:2.44-1/
Comment 2 Andrew G. Morgan 2021-08-20 02:47:33 UTC 
https://sources.debian.org/src/libcap2/1:2.44-1/debian/rules/

seems to be stuck in the rut of thinking 'make test' requires root. Whereas, 'make sudotest' was, at some point factored out in order for 'make test' to be runnable as anyone.
Comment 3 Andrew G. Morgan 2021-08-20 03:55:28 UTC 
I've dropped the use of IPATH and replaced it with CPPFLAGS in approximately the way it was done in the gentoo patch:

https://git.kernel.org/pub/scm/libs/libcap/libcap.git/commit/?id=d21a561ddb80cdc039f32eb5225f5d398d221291
Comment 4 Andrew G. Morgan 2021-08-20 23:33:56 UTC 
This is what archlinux uses:

https://github.com/archlinux/svntogit-packages/tree/master/libcap/trunk
Comment 5 Andrew G. Morgan 2021-08-23 13:55:16 UTC 
KaOSx libcap has a nice build file with one stale dependency: https://github.com/KaOSx/core/issues/28
Comment 6 Andrew G. Morgan 2021-08-23 14:39:57 UTC 
T2 SDE (http://t2sde.org/packages/libcap) seems to be carrying this patch:

http://svn.exactcode.de/t2/trunk/package/base/libcap/hotfix.patch
Comment 7 Andrew G. Morgan 2021-08-26 02:53:44 UTC 
The T2 patch looks stale to me. It checks for something that is now always defined from the previous lines of the cap_file.c.