Bug 211071

Summary: ACPI errors when plugin/unplugin AC on Lenovo T14s
Product: ACPI Reporter: Robert de Rooy (robert.de.rooy)
Component: ACPICA-CoreAssignee: Zhang Rui (rui.zhang)
Status: CLOSED DOCUMENTED    
Severity: normal CC: rui.zhang
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 5.9.16-200.fc33.x86_64 Subsystem:
Regression: No Bisected commit-id:
Attachments: T14s acpidump

Description Robert de Rooy 2021-01-07 10:55:49 UTC 
Similar to closed issue https://bugzilla.kernel.org/show_bug.cgi?id=203199 I am getting ACPI errors on a new T14s running the latest bios release (1.14) when plugging and unplugging the power supply.
https://support.lenovo.com/lu/en/downloads/ds544146-bios-update-utility-bootable-cd-for-windows-10-64-bit-and-linux-thinkpad-t14s-gen-1-x13-gen-1

Jan 07 11:31:09 t14s kernel: ACPI BIOS Error (bug): AE_AML_PACKAGE_LIMIT, Index (0x000000011) is beyond end of object (length 0x0) (20200717/exoparg2-393)
Jan 07 11:31:09 t14s kernel: ACPI Error: Aborting method \_SB.PCI0.LPCB.EC.BRNS due to previous error (AE_AML_PACKAGE_LIMIT) (20200717/psparse-529)
Jan 07 11:31:09 t14s kernel: ACPI Error: Aborting method \_SB.PCI0.LPCB.EC._Q26 due to previous error (AE_AML_PACKAGE_LIMIT) (20200717/psparse-529)

$ dmesg |grep thinkpad
[    7.578119] thinkpad_acpi: ThinkPad ACPI Extras v0.26
[    7.578120] thinkpad_acpi: http://ibm-acpi.sf.net/
[    7.578120] thinkpad_acpi: ThinkPad BIOS N2YET25W (1.14 ), EC N2YHT16W
[    7.578121] thinkpad_acpi: Lenovo ThinkPad T14s Gen 1, model 20T0S1CV00
[    7.578396] thinkpad_acpi: radio switch found; radios are enabled
[    7.578409] thinkpad_acpi: This ThinkPad has standard ACPI backlight brightness control, supported by the ACPI video driver
[    7.578411] thinkpad_acpi: Disabling thinkpad-acpi brightness events by default...
[    7.580037] thinkpad_acpi: rfkill switch tpacpi_bluetooth_sw: radio is unblocked
[    7.581125] thinkpad_acpi: rfkill switch tpacpi_wwan_sw: radio is blocked
[    7.594563] thinkpad_acpi: battery 1 registered (start 0, stop 100)
[    7.595680] input: ThinkPad Extra Buttons as /devices/platform/thinkpad_acpi/input/input23
[   74.754790] thinkpad_acpi: undocked from hotplug port replicator
[   80.392160] thinkpad_acpi: docked into hotplug port replicator
[23592.521308] thinkpad_acpi: undocked from hotplug port replicator
[76093.951061] thinkpad_acpi: docked into hotplug port replicator
[86467.204078] thinkpad_acpi: undocked from hotplug port replicator
[86571.914240] thinkpad_acpi: docked into hotplug port replicator

$ fwupdmgr update
Devices with no available firmware updates: 
 • Thunderbolt host controller
 • USB3.1 Hub
 • USB3.1 Hub
 • Integrated Camera
 • UEFI Device Firmware
 • UEFI Device Firmware
 • UEFI Device Firmware
 • UEFI dbx
 • USB2.0 Hub
 • USB2.0 Hub
 • Unifying Receiver
 • VMM5322
Devices with the latest available firmware version:
 • Embedded Controller
 • Intel Management Engine
 • KXG6AZNV1T02 TOSHIBA
 • Prometheus
 • Prometheus IOTA Config
 • System Firmware
Comment 1 Zhang Rui 2021-03-04 06:37:56 UTC 
(In reply to Robert de Rooy from comment #0)
> Similar to closed issue https://bugzilla.kernel.org/show_bug.cgi?id=203199 I
> am getting ACPI errors on a new T14s running the latest bios release (1.14)
> when plugging and unplugging the power supply.
> https://support.lenovo.com/lu/en/downloads/ds544146-bios-update-utility-
> bootable-cd-for-windows-10-64-bit-and-linux-thinkpad-t14s-gen-1-x13-gen-1
> 
> Jan 07 11:31:09 t14s kernel: ACPI BIOS Error (bug): AE_AML_PACKAGE_LIMIT,
> Index (0x000000011) is beyond end of object (length 0x0)
> (20200717/exoparg2-393)
> Jan 07 11:31:09 t14s kernel: ACPI Error: Aborting method
> \_SB.PCI0.LPCB.EC.BRNS due to previous error (AE_AML_PACKAGE_LIMIT)
> (20200717/psparse-529)
> Jan 07 11:31:09 t14s kernel: ACPI Error: Aborting method
> \_SB.PCI0.LPCB.EC._Q26 due to previous error (AE_AML_PACKAGE_LIMIT)
> (20200717/psparse-529)

This is caused by the bogus AML code.
To confirm this, please attach the acpidump output.
As it might be harmless, did you observe any functionality problems other than the error messages?
Comment 2 Robert de Rooy 2021-03-04 08:14:56 UTC 
Created attachment 295641 [details]
T14s acpidump

Here is the acpidump. I am not aware of any negative issue of the error.
Comment 3 Robert de Rooy 2021-03-04 08:19:16 UTC 
Here are the errors with kernel-5.10.19-200.fc33.x86_64

[    5.719663] ACPI Error: Needed [Integer/String/Buffer], found [Package] 00000000adbd0418 (20200925/exresop-469)
[    5.719668] ACPI Error: AE_AML_OPERAND_TYPE, While resolving operands for [OpcodeName unavailable] (20200925/dswexec-431)
[    5.719670] ACPI Error: Aborting method \ADBG due to previous error (AE_AML_OPERAND_TYPE) (20200925/psparse-529)
[    5.719675] ACPI Error: Aborting method \_SB.HIDD._DSM due to previous error (AE_AML_OPERAND_TYPE) (20200925/psparse-529)
[    5.719683] ACPI: \_SB_.HIDD: failed to evaluate _DSM (0x3003)
Comment 4 Zhang Rui 2021-03-21 16:09:21 UTC 
So in \_SB.HIDD._DSM,
            Method (_DSM, 4, Serialized)  // _DSM: Device-Specific Method
            {
                If ((Arg0 == ToUUID ("eeec56b3-4442-408f-a792-4edd4d758054")))
                {
                    ADBG ("HID Para STR-")
                    ADBG (Arg0)
                    ADBG (":")
                    ADBG (Arg1)
                    ADBG (":")
                    ADBG (Arg2)
                    ADBG (":")
                    ADBG (Arg3)
ADBG does not support package, but the AML code uses ADBG in a bogus way.
This is a BIOS bug, although I'm pretty sure it won't bring any side effect.

Bug closed, you can raise the problem to Lenovo if you want to get it fixed.
Comment 5 Robert de Rooy 2021-03-24 13:23:42 UTC 
I have raised the issue here: https://forums.lenovo.com/topic/findpost/15028/5072269/5289850

FYI, BIOS 1.15 has the same issue.