Bug 208385

Summary: asus-wmi: charge_control_end_threshold does not appear within BAT1
Product: Drivers Reporter: Mark Francis Enriquez (enriquezmark36)
Component: Platform_x86Assignee: drivers_platform_x86 (drivers_platform_x86)
Status: RESOLVED PATCH_ALREADY_AVAILABLE    
Severity: low CC: andy.shevchenko
Priority: P1    
Hardware: Intel   
OS: Linux   
Kernel Version: 5.4.41 Subsystem:
Regression: No Bisected commit-id:

Description Mark Francis Enriquez 2020-06-30 13:14:42 UTC 
Hello,

I was wondering about the "charge_control_end_threshold" in asus-wmi. I'm using an Asus x571gt-bq098t which only have a single battery and yet the battery is named neither at BAT0 or BATT but BAT1.

I don't think that it's because the "charge_control_end_threshold" is not supported on this device (disregarding the fact that ASUS had a simillar feature on their pre-loaded Windows install). 

Should they also check if it's BAT1?

P.S.
To further test things out, I recompiled the 5.4.41 kernel and added an additional line to check if it could be "BATT1". The "charge_control_end_threshold" is now present and actually limits the charging percentage.
Comment 1 Andy Shevchenko 2020-07-15 05:36:24 UTC 
I believe we have a fix already, targeting v5.9.
http://git.infradead.org/linux-platform-drivers-x86.git/commit/a6146ab8a57b6a84e3643398605ec6f897a69365

Feel free to reopen, if it doesn't help.