Bug 207603

Summary: S2idle loops in s2idle_enter before actually entering s2idle
Product: Power Management Reporter: Todd Brandt (todd.e.brandt)
Component: OtherAssignee: Rafael J. Wysocki (rjw)
Status: RESOLVED PATCH_ALREADY_AVAILABLE    
Severity: normal CC: lenb
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 5.7.0-rc2 Subsystem:
Regression: No Bisected commit-id:
Bug Depends on:    
Bug Blocks: 178231    
Attachments: otcpl-dell-p3520-with-loop-stripped.html
dmesg.txt
ftrace.txt
ftrace_with_just_suspend_resume_trace_points.txt
issue.def
issue.def

Description Todd Brandt 2020-05-06 12:47:44 UTC
Created attachment 288961 [details]
otcpl-dell-p3520-with-loop-stripped.html

When running stress testing, occasionally the s2idle_enter code will enter an infinite loop instead of waiting. The suspend_machine tracepoints are called hundreds of thousands of times during a 10 second period. It happens on many unrelated machines. It prevents timeline generation because the code html cannot render hundreds of thousands of suspend machine & resume machine phases.

Dell p3520
Whiskey Lake U
Dell XPS 13 9300
Amber Lake Y

Attached are the logs for the Dell p3520 run and a timeline with the infinite loop trimmed out.
Comment 1 Todd Brandt 2020-05-06 12:48:14 UTC
Created attachment 288963 [details]
dmesg.txt
Comment 2 Todd Brandt 2020-05-06 12:49:23 UTC
Created attachment 288965 [details]
ftrace.txt
Comment 3 Todd Brandt 2020-05-06 12:50:13 UTC
Created attachment 288967 [details]
ftrace_with_just_suspend_resume_trace_points.txt
Comment 4 Rafael J. Wysocki 2020-05-09 09:03:00 UTC
This should be fixed by https://patchwork.kernel.org/patch/11538065/ if I'm not mistaken.
Comment 5 Todd Brandt 2020-05-13 18:10:09 UTC
Created attachment 289119 [details]
issue.def
Comment 6 Todd Brandt 2020-05-13 18:11:21 UTC
Created attachment 289121 [details]
issue.def