Bug 205185

Summary: amdgpu compile failure
Product: Drivers Reporter: Stijn Tintel (stijn+bugs)
Component: Video(DRI - non Intel)Assignee: drivers_video-dri
Status: RESOLVED OBSOLETE    
Severity: blocking CC: alexdeucher, steven
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 5.3.5 - 5.3.10 Subsystem:
Regression: No Bisected commit-id:

Description Stijn Tintel 2019-10-14 08:32:35 UTC
5.3.5 and 5.3.6 do not compile:

drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dpp.c: In function ‘dpp2_cnv_setup’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dpp.c:94:30: note: byref variable will be forcibly initialized
  struct out_csc_color_matrix tbl_entry;
                              ^~~~~~~~~
  CC [M]  drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hubbub.o
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c: In function ‘dcn20_init_hw’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:589:37: error: ‘const struct resource_caps’ has no member named ‘num_dsc’; did you mean ‘num_ddc’?
  for (i = 0; i < res_pool->res_cap->num_dsc; i++)
                                     ^~~~~~~
                                     num_ddc
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:590:3: error: implicit declaration of function ‘dcn20_dsc_pg_control’; did you mean ‘dcn20_dpp_pg_control’? [-Werror=implicit-function-declaration]
   dcn20_dsc_pg_control(hws, res_pool->dscs[i]->inst, false);
   ^~~~~~~~~~~~~~~~~~~~
   dcn20_dpp_pg_control
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:590:39: error: ‘struct resource_pool’ has no member named ‘dscs’; did you mean ‘dpps’?
   dcn20_dsc_pg_control(hws, res_pool->dscs[i]->inst, false);
                                       ^~~~
                                       dpps
Comment 1 Alex Deucher 2019-11-11 17:45:44 UTC
Make sure CONFIG_DRM_AMD_DC_DSC_SUPPORT=y in your config.
Comment 2 Stijn Tintel 2019-11-11 20:23:38 UTC
Thanks. Enabling that symbol fixes the compile failure. This wasn't a problem in 5.3.0 - 5.3.4, so there's a regression introduced in 5.3.5, which should still be fixed. Probably needs a dependency in some Kconfig file.
Comment 3 Stijn Tintel 2021-12-08 09:53:41 UTC
As more recent kernels don't seem to have DRM_AMD_DC_DSC_SUPPORT anymore, I don't know how to reproduce this anymore so let's just close it.