Bug 204513

Summary: Goodix touch screen ( Goodix-TS i2c-GDIX1002:00: ID 9111, version: 2020 ) - STYLUS during hoovering touches UI, buttons etc
Product: Drivers Reporter: Miroslaw Kocur (mirek190)
Component: Input DevicesAssignee: drivers_input-devices
Status: RESOLVED CODE_FIX    
Severity: normal CC: jwrdegoede, mirek190
Priority: P1    
Hardware: x86-64   
OS: Linux   
Kernel Version: 4.x up to 5.x Subsystem:
Regression: No Bisected commit-id:
Attachments: goodix panel - finger touch
goodix panel - stylus hovering

Description Miroslaw Kocur 2019-08-05 23:13:42 UTC
Created attachment 284207 [details]
goodix panel - finger touch

HELLO 

Let's straight to the point ;-)

Problem :
The the stylus for the touch screen ( Goodix-TS i2c-GDIX1002:00: ID 9111, version: 2020 ) under ANDROID and LINUX.

The stylus works .. but :
- hoovering over the screen triggering BTN_TOUCH ( but shouldn't ! ) so trigger buttons , sliders , etc.
As you know should do it ( BTN_TOUCH ) after touch the screen ... not earlier...

Like you see on the pictures ( longer selection is for the stylus hoover and shorter one for the finger ) system is not able to recognize if we're using the finger or the stylus .
I'm getting exactly the same data ...

I checked the goodix.c parameters but is not returning anything about the hovering or the stylus ...

The only difference I noticed is during hoovering the stylus returning parameter ABS_MT_WIDTH_MAJOR = 0 but touching by the finger to touching by the stylus return = ! 0.


If you need any mode data please ask.


Thanks for help .
Comment 1 Miroslaw Kocur 2019-08-05 23:16:26 UTC
Created attachment 284209 [details]
goodix panel - stylus hovering
Comment 2 Hans de Goede 2021-12-07 17:32:25 UTC
Good news, I've written a patch to properly report the stylus/pen events as stylus events and submitted this upstream, see:
https://lore.kernel.org/linux-input/20211207100754.31155-1-hdegoede@redhat.com/T/#t