Bug 204317
Summary: | DVBSky T9580 V3 IR receiver not working any more since 5.1 | ||
---|---|---|---|
Product: | Drivers | Reporter: | Laz Lev (lazlev) |
Component: | Input Devices | Assignee: | drivers_other |
Status: | RESOLVED CODE_FIX | ||
Severity: | normal | CC: | ailin.nemui+kernel, jiloxe4653, lazlev, sean |
Priority: | P1 | ||
Hardware: | x86-64 | ||
OS: | Linux | ||
Kernel Version: | 5.1 | Subsystem: | |
Regression: | Yes | Bisected commit-id: | |
Attachments: |
Add some debugging to IR receiving
Add IR debugging and attempt to fix interrupts Add IR debugging and attempt to fix interrupts and timeout |
Description
Laz Lev
2019-07-25 20:22:42 UTC
same issue on OpenSUSE 15.2 kernel 5.3.18, it either doesn't work or registers double presses, or wrong presses I bisected between kernel 5.0 and 5.1 and found the commit that breaks my IR receiver. Hopefully this can be resolved now? $ git -C ./src/linux bisect bad a49a7a4635dea5b799a8f77e227ef5c648fa29ec is the first bad commit commit a49a7a4635dea5b799a8f77e227ef5c648fa29ec Author: Patrick Lerda <patrick9876@free.fr> Date: Wed Jan 23 19:04:20 2019 -0500 media: smipcie: add universal ir capability smipcie: switch to RC_DRIVER_IR_RAW. Signed-off-by: Patrick Lerda <patrick9876@free.fr> Signed-off-by: Sean Young <sean@mess.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> drivers/media/pci/smipcie/smipcie-ir.c | 132 +++++++++++---------------------- drivers/media/pci/smipcie/smipcie.h | 1 - 2 files changed, 45 insertions(+), 88 deletions(-) This commit changes the IR handling, it is very possible that there was a regression there. Please can you send the output of: ir-ctl -r (and then press some buttons) Thanks. On linux 5.0 (where my remote is still working) I get the following error: $ ir-ctl -r /dev/lirc0: device cannot receive raw ir On linux 5.1 (where my remote stops working) I neither get an error nor any output when pressing buttons. Features are reported like this: $ ir-ctl -f Receive features /dev/lirc0: - Device can receive raw IR - Can report decoded scancodes and protocol - Resolution 83 microseconds - Receiving timeout 100000 microseconds Send features /dev/lirc0: - Device cannot send And device is detected like this during boot: rc rc0: lirc_dev: driver SMI_PCIe registered at minor = 0, raw IR receiver, no transmitter lircd is installed with devinput driver: $ lircd --version lircd 0.10.1 Some more information about how I configured my remote so far: $ cp /lib/udev/rc_keymaps/dvbsky.toml /etc/rc_keymaps/ $ cat /etc/rc_keymaps/dvbsky.toml [[protocols]] name = "dvbsky" protocol = "rc5" variant = "rc5" [protocols.scancodes] 0x0000 = "KEY_0" 0x0001 = "KEY_1" 0x0002 = "KEY_2" 0x0003 = "KEY_3" 0x0004 = "KEY_4" 0x0005 = "KEY_5" 0x0006 = "KEY_6" 0x0007 = "KEY_7" 0x0008 = "KEY_8" 0x0009 = "KEY_9" 0x000a = "KEY_MUTE" 0x000d = "KEY_OK" 0x000b = "KEY_STOP" 0x000c = "KEY_EXIT" 0x000e = "KEY_CAMERA" 0x000f = "KEY_SUBTITLE" 0x0010 = "KEY_VOLUMEUP" 0x0011 = "KEY_VOLUMEDOWN" 0x0012 = "KEY_FAVORITES" 0x0013 = "KEY_LIST" 0x0016 = "KEY_PAUSE" 0x0017 = "KEY_PLAY" 0x001f = "KEY_RECORD" 0x0020 = "KEY_CHANNELDOWN" 0x0021 = "KEY_CHANNELUP" 0x0025 = "KEY_POWER2" 0x0026 = "KEY_REWIND" 0x0027 = "KEY_FASTFORWARD" 0x0029 = "KEY_LAST" 0x002b = "KEY_MENU" 0x002c = "KEY_EPG" 0x002d = "KEY_ZOOM" 0x14 = "KEY_UP" 0x15 = "KEY_DOWN" 0x18 = "KEY_LEFT" 0x19 = "KEY_RIGHT" 0x1a = "KEY_RED" 0x1b = "KEY_GREEN" 0x1c = "KEY_YELLOW" 0x1d = "KEY_BLUE" $ ir-keytable -a /etc/rc_maps.cfg -s rc0 Old keytable cleared Wrote 40 keycode(s) to driver Protocols changed to rc-5 Thanks for helping me! Created attachment 294695 [details]
Add some debugging to IR receiving
This patch adds some extra debugging so we can see what the hardware is producing.
Please can you try the patch and tell us if there is any output in dmesg when you press some buttons. Thanks I applied the patch and got some key presses recognized right after reboot. After 2-3 seconds it stopped working and nothing gets logged anymore (I guess some hard crash?). Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: count 00000001 Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 00000001 Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 8b158b0b Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 950a8b0a Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 95159515 Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 0000000a Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 8b158b0b Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 8b0a8b0b Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 95159515 Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 0000000a Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: count 00000001 Jan 17 16:46:02 medianas kernel: rc rc0: smi_ir_decode: data 00000001 Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 8b0a8b0b Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b15 Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 95159515 Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 0000000a Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 8b158b0b Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 95159615 Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 0000000a Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b15 Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 95159615 Jan 17 16:46:03 medianas kernel: rc rc0: smi_ir_decode: data 0000000a Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: data 8b158b0b Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: data 950a8b0b Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: data 95159515 Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: data 0000000a Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b15 Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: data 95159515 Jan 17 16:46:04 medianas kernel: rc rc0: smi_ir_decode: data 0000000a Sean Young: So I'm guessing the debug output I gave was not very helpful? Anything else we can try to locate the problem? Do you know of any way to contact the original author Patrick Lerda? Last time I checked his mail box was full... reverting that commit fixes my remote Looks like the device reports IR fine and then stops. I don't know this driver either; neither do I have the hardware to experiment with. I've emailed the patch author and also got a mailbox full bounce. So having read the driver code, it does some odd things which I can' explain. Disabling interrupts for each irq is unusual. I'm not sure they're being re-enabled correctly. Please can you change line 179 from smi_set(IR_Init_Reg, rbIRhighidle); to: smi_set(IR_Init_Reg, rbIRen | rbIRhighidle); Possibly this will work, but this is guesswork I'm afraid. I wanted to test your proposed change but there are three places where smi_set() is called: line 83 line 92 line 121 https://github.com/torvalds/linux/blob/master/drivers/media/pci/smipcie/smipcie-ir.c Line 121 is already set to the way you proposed so should I change line 83 and/or line 92? Sorry, just saw that only line 92 exactly matches what you mentioned so I went ahead and changed that line to: smi_set(IR_Init_Reg, rbIRen | rbIRhighidle); Unfortunately it did not fix the issue. Same behavior as before... Created attachment 294985 [details] Add IR debugging and attempt to fix interrupts The vendor code is here: http://dvbsky.net/download/linux/ I *hope* that now I've figured out what the problem is, and now the code matches what the original vendor code was done. Please can you test this patch, and let me know if it works. Please include what the dmesg output please, whether it works or not. Thank you very much! For reference, here was the original thread with working driver https://patchwork.kernel.org/project/linux-media/patch/201506292209394689855@gmail.com/ Sean, I just tested your patch and I can confirm that it is working *almost* perfectly now. I'm catching some double presses now although I only pressed once but other than that it continues working. Here's some output from journalctl -k: Jan 29 20:58:17 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 29 20:58:17 medianas kernel: rc rc0: smi_ir_decode: count 00000001 Jan 29 20:58:17 medianas kernel: rc rc0: smi_ir_decode: data 00000001 Jan 29 20:58:17 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 29 20:58:17 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 29 20:58:17 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 29 20:58:17 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 29 20:58:17 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b15 Jan 29 20:58:17 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 29 20:58:17 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 29 20:58:17 medianas kernel: rc rc0: smi_ir_decode: data 95159515 Jan 29 20:58:17 medianas kernel: rc rc0: smi_ir_decode: data 0000000b Jan 29 20:58:17 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: data 8b158b0b Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: data 95159515 Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: data 0000000b Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b15 Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: data 95159515 Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: data 0000000b Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: count 00000001 Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: data 00000002 Jan 29 20:58:18 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 8b158b0b Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 8b0a8b0b Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 95159515 Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 0000000b Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b15 Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 95159515 Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 0000000b Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 8b158b0b Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 95159515 Jan 29 20:58:19 medianas kernel: rc rc0: smi_ir_decode: data 0000000b Thank you for testing the patch! I think we're almost there. Created attachment 294997 [details]
Add IR debugging and attempt to fix interrupts and timeout
The drivers sets the timeout length to 100ms but then only generates timeouts of 10ms.
I just tested the new patch and now it seems to work perfectly. At least I couldn't find any more issues with it after playing around a little with it. I think this patch can be submitted to the kernel to fix the issue. Here's some debug output: Jan 30 14:36:23 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 30 14:36:23 medianas kernel: rc rc0: smi_ir_decode: data 8b158b0b Jan 30 14:36:23 medianas kernel: rc rc0: smi_ir_decode: data 000b8b0b Jan 30 14:36:23 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: count 00000017 Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b15 Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: data 8b0a8b0b Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: data 8b158b0b Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: data 000b8b0b Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: data 8b158b0b Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0a Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: data 8b159515 Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: data 0000000b Jan 30 14:36:24 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b15 Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: data 8b159515 Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: data 0000000b Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: data 8b158b0b Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: data 8b0a8b0b Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0b Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: data 8b159515 Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: data 0000000b Jan 30 14:36:25 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 30 14:36:26 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 30 14:36:26 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 30 14:36:26 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0b Jan 30 14:36:26 medianas kernel: rc rc0: smi_ir_decode: data 8b0a8b14 Jan 30 14:36:26 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0a Jan 30 14:36:26 medianas kernel: rc rc0: smi_ir_decode: data 950b8b0a Jan 30 14:36:26 medianas kernel: rc rc0: smi_ir_decode: data 96159615 Jan 30 14:36:26 medianas kernel: rc rc0: smi_ir_decode: data 0000000a Jan 30 14:36:26 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 30 14:36:26 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 30 14:36:26 medianas kernel: rc rc0: smi_ir_decode: count 00000001 Jan 30 14:36:26 medianas kernel: rc rc0: smi_ir_decode: data 00000001 Jan 30 14:36:26 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 30 14:36:27 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 30 14:36:27 medianas kernel: rc rc0: smi_ir_decode: count 00000015 Jan 30 14:36:27 medianas kernel: rc rc0: smi_ir_decode: data 8b158b0b Jan 30 14:36:27 medianas kernel: rc rc0: smi_ir_decode: data 8b0a8b0a Jan 30 14:36:27 medianas kernel: rc rc0: smi_ir_decode: data 8b0b8b0a Jan 30 14:36:27 medianas kernel: rc rc0: smi_ir_decode: data 950a8b0a Jan 30 14:36:27 medianas kernel: rc rc0: smi_ir_decode: data 96149614 Jan 30 14:36:27 medianas kernel: rc rc0: smi_ir_decode: data 0000000a Jan 30 14:36:27 medianas kernel: rc rc0: smi_ir_decode: high idle Jan 30 14:36:30 medianas kernel: rc rc0: smi_ir_decode: control 00000094 Jan 30 14:36:30 medianas kernel: rc rc0: smi_ir_decode: count 00000063 Wonderful. I've cleaned up the patch. This includes some changes to make it conform to current coding standards (aka checkpatch.pl). https://www.spinics.net/lists/linux-media/msg186295.html Hey Sean, thanks again for putting in the time to fix this problem. Much appreciated! Do you know how long it normally takes to review and accept kernel patches like this? Is there some kind of auto-accept mechanism after a period of time with no activity? Just wondering what's the normal procedure here. I'm not in a big hurry but still would love to see this applied sooner rather than later of course :) Patch has been applied and will be part of the upcoming kernel 5.12. Thanks Sean! |