Bug 204135
| Summary: | F2FS: BUG: KASAN: null-ptr-deref in mempool_alloc+0xd8/0x2e0 | ||
|---|---|---|---|
| Product: | File System | Reporter: | midwinter1993 |
| Component: | f2fs | Assignee: | Default virtual assignee for f2fs (filesystem_f2fs) |
| Status: | RESOLVED CODE_FIX | ||
| Severity: | normal | CC: | chao |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 5.1.3 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
|
Description
midwinter1993
2019-07-11 07:18:06 UTC
I've sent one patch to fix this issue, just simply refusing remount w/ io_bits change, could you have a try? https://lore.kernel.org/linux-f2fs-devel/20190712085700.4239-1-yuchao0@huawei.com/T/#u (In reply to Chao Yu from comment #1) > I've sent one patch to fix this issue, just simply refusing remount w/ > io_bits change, could you have a try? > > https://lore.kernel.org/linux-f2fs-devel/20190712085700.4239-1- > yuchao0@huawei.com/T/#u I have tested this patch but have compiling errors: > /linux-5.1.3/fs/f2fs/super.c:1538:22: error: implicit declaration of function F2FS_IO_ALIGNED; did you mean F2FS_BLK_ALIGN? [-Werror=implicit-function-declaration] > /linux-5.1.3/fs/f2fs/super.c:1621:3: error: implicit declaration of function f2fs_warn [-Werror=implicit-function-declaration] I "grep" the whole file system directory but not found the symbol "F2FS_IO_ALIGNED" and "f2fs_warn". Should I change the kernel version to test? F2FS_IO_ALIGNED() was defined in last patch for your previous issue... so, should apply them before this patch. Could you change to last code in dev branch in Jaegeuk's git repo. https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/log/?h=dev (In reply to Chao Yu from comment #3) > F2FS_IO_ALIGNED() was defined in last patch for your previous issue... so, > should apply them before this patch. > > Could you change to last code in dev branch in Jaegeuk's git repo. > > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/log/?h=dev Hi! I tested the patch under commit: > Hash: e3110f4; f2fs: fix to read source block before invalidating it But the F2FS_IO_ALIGNED was still missing!? (Or something wrong I did?) Sorry, I meant I made the two fix patches based Jaegeuk's git repo, however Jaegeuk hasn't merge the two patches in his branch. So you can do the merge by yourself, or you can use below codes in my repo, I've update the all fixes on it. https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/log/?h=dev (In reply to Chao Yu from comment #5) > Sorry, I meant I made the two fix patches based Jaegeuk's git repo, however > Jaegeuk hasn't merge the two patches in his branch. > > So you can do the merge by yourself, or you can use below codes in my repo, > I've update the all fixes on it. > > https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/log/?h=dev I have tested several times in your repo and under dev branch; the above-mentioned bug did not happen anymore. :-P Thanks for the test, let me close this track. :) |