Bug 203565

Summary:	Consider adapting the Makefiles to make it easier to package trace-cmd and kernelshark
Product:	Tools	Reporter:	Bas van Dijk (v.dijk.bas)
Component:	Trace-cmd/Kernelshark	Assignee:	Default virtual assignee for Trace-cmd and kernelshark (tools_tracecmd_kernelshark)
Status:	RESOLVED CODE_FIX
Severity:	enhancement	CC:	ykaradzhov
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	4.19	Subsystem:
Regression:	No	Bisected commit-id:

Description Bas van Dijk 2019-05-10 16:30:57 UTC

I'm packaging trace-cmd and kernelshark for NixOS here:

https://github.com/NixOS/nixpkgs/pull/60367

In the process I had to slightly modify the Makefile and CMakeLists.txt files. See the diffs here:

https://github.com/NixOS/nixpkgs/blob/18277491cdd463fb0d9696fa2d76956eb67b0e89/pkgs/os-specific/linux/trace-cmd/fix-Makefiles.patch

https://github.com/NixOS/nixpkgs/blob/18277491cdd463fb0d9696fa2d76956eb67b0e89/pkgs/os-specific/linux/trace-cmd/fix-kernel-shark-CMakeLists.txt.patch

Would it be possible to upstream these changes?

Comment 1 Yordan Karadzhov 2019-05-15 19:23:49 UTC

Hello,
Thank you very much for the help!

The cmake-related part of the changes that you propose has been included in this patch

https://lore.kernel.org/linux-trace-devel/20190515190911.20755-2-ykaradzhov@vmware.com/T/#u

which aims to remove all hard-coded install paths for KernelShark.

Please note that KernelShark is still at version 9.8 and we do not consider it ready to became a package yet.

Thanks!
Yordan