Bug 202195
Summary: | Regression: since Linux 4.18rc1 Trust Flex Graphics Tablet incorrectly detected as mouse, so no Pen input device, no pressure detection, etc. | ||
---|---|---|---|
Product: | Drivers | Reporter: | RussianNeuroMancer (russianneuromancer) |
Component: | Input Devices | Assignee: | drivers_input-devices |
Status: | NEW --- | ||
Severity: | normal | CC: | benjamin.tissoires, delgan.py, dmitry.torokhov, skl.cherem |
Priority: | P1 | ||
Hardware: | Intel | ||
OS: | Linux | ||
Kernel Version: | 4.18rc1 | Subsystem: | |
Regression: | Yes | Bisected commit-id: |
Description
RussianNeuroMancer
2019-01-09 12:31:08 UTC
Thanks Dmitry for triaging this to me (actually, I was part of https://gitlab.freedesktop.org/libinput/libinput/issues/64 that lead to this bug report). So I know I pointed the reporter to the DIGImend project already. But out of curiosity, it would be interesting to see if adding your PID (0004) to hid-uclogic and see how this behaves (replace USB_DEVICE_ID_UGEE_TABLET_EX07S by 0004, recompile and reload the driver). I noticed that VendorID of Trust Flex Graphics Tablet (2179) is different from USB_VENDOR_ID_UGEE (0x28bd) so instead of replacing SB_DEVICE_ID_UGEE_TABLET_EX07S by 0004, I changed line "#define USB_DEVICE_ID_UGTIZER_TABLET_GP0610 0x0053" to "#define USB_DEVICE_ID_UGTIZER_TABLET_GP0610 0x0004" because USB_VENDOR_ID_UGTIZER is similar to VendorID of Trust Flex Graphics Tablet (2179). https://github.com/torvalds/linux/blob/bd8879faafe6d057237461c4d58d8b0d37b9e3ee/drivers/hid/hid-ids.h#L1238 I rebuild Linux 4.20 with change and find that tablet is still detected as mouse, so issue is still reproducible. Obviously, my assumption above could be wrong, so maybe I still need to edit hid-uclogic.c to apply necessary change? If I still need to put PID 0004 somewhere in hid-uclogic.c, what I should replace with 0004, USB_DEVICE_ID_UGEE_TABLET_EX07S in lines 979 and 1072, or USB_DEVICE_ID_UGTIZER_TABLET_GP0610 in lines 978 and 1071? How I should put 0004 here, just like 0004 or maybe like 0x0004? https://github.com/torvalds/linux/blob/bd8879faafe6d057237461c4d58d8b0d37b9e3ee/drivers/hid/hid-uclogic.c#L978 https://github.com/torvalds/linux/blob/bd8879faafe6d057237461c4d58d8b0d37b9e3ee/drivers/hid/hid-uclogic.c#L1071 I have same Flex Design Tablet. After upgrade from Ubuntu 18.04 to Ubuntu 18.10 I now have same issue. Is there other way to workaround this besides booting Linux 4.17 kernel? https://github.com/linuxwacom/libwacom/issues/63 > In that case libwacom can't do anything and this needs to be fixed in the > kernel. Since there's another issue with the missing BTN_TOOL_PEN as well, > I'm going to say the kernel needs to be fixed here first FYI, hid-uclogic has been greatly enhanced in linux-next: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/log/?h=for-5.1/hid-uclogic It could be interesting to see if adding your tablet IDs in this new code helps or not. Should I do this in the same way as described in first paragraph of Comment 2? If not, how exactly I should edit hid-uclogic.c? (See questions in third paragraph of Comment 2.) As I see this code was shipped in Linux 5.1. I tested Linux 5.2.1 with same change as described in Comment 2. This does not help. Benjamin, please let me know - is there anything else I could check on my side? I tested tablet again with Linux 5.5.0 and Linux 5.6rc4. With both kernels tablet regressed further. Not only it's still recognised as mouse, but stylus buttons is no longer detected now. Please let me know if I should proceed with bisect? Asking because I not sure if anyone is working on this issue currently. |