Bug 201519

Overview:

After kernel update, system no longer resumes from suspend.

Steps to Reproduce:

1) Suspend (e.g. by closing notebook lid)
2) Hit power button to resume

Actual Results:

Power LED is switched ON and nothing more happens. Screen remains black,
system is not responding even to SysRq commands, no requests to HDD is made.

Expected Results: 

System resumes to working state.

Build:

All kernels since c62ec4610c40bcc44f2d3d5ed1c312737279e2f3, including latest
upstream - v4.19 at the moment. Does not occur on 4.16.* kernels.

git bisect output:
c62ec4610c40bcc44f2d3d5ed1c312737279e2f3 is the first bad commit
commit c62ec4610c40bcc44f2d3d5ed1c312737279e2f3
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Date:   Tue May 22 13:02:17 2018 +0200

    PM / core: Fix direct_complete handling for devices with no callbacks
    
    Commit 08810a4119aa (PM / core: Add NEVER_SKIP and SMART_PREPARE
    driver flags) inadvertently prevented the power.direct_complete flag
    from being set for devices without PM callbacks and with disabled
    runtime PM which also prevents power.direct_complete from being set
    for their parents.  That led to problems including a resume crash on
    HP ZBook 14u.
    
    Restore the previous behavior by causing power.direct_complete to be
    set for those devices again, but do that in a more direct way to
    avoid overlooking that case in the future.
    
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=199693
    Fixes: 08810a4119aa (PM / core: Add NEVER_SKIP and SMART_PREPARE driver flags)
    Reported-by: Thomas Martitz <kugel@rockbox.org>
    Tested-by: Thomas Martitz <kugel@rockbox.org>
    Cc: 4.15+ <stable@vger.kernel.org> # 4.15+
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
    Reviewed-by: Johan Hovold <johan@kernel.org>

:040000 040000 24388033a6e19486a816ae483b7a30dc8feb3de2 51921e87fbf3715cd3705f59f2216a886f4ca5d5 M      drivers

Additional Information:

Systemd journal does not have anything after entering suspend.
Applying this patch on upstream (or any other revision) seems to fix the issue:
diff --git a/drivers/base/power/main.c b/dric
index a690fd400260..ad827119c280 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -1944,7 +1944,7 @@ static int device_prepv, pm_message_t state)
 unlock:
        device_unlock(dev);
 
-       if (ret < 0) {
+       if (ret < 0 || dev->power.no_pm_call
                suspend_report_result(callba
                pm_runtime_put(dev);
                return ret;

However, it is effectively the same as reverting commit
c62ec4610c40bcc44f2d3d5ed1c312737279e2f3, so I have no idea how to investigate
this further.

System:

HP ProBook 4540s
openSUSE Tumbleweed
Intel(R) Core(TM) i5-3230M CPU @ 2.60GHz

lspci output:

00:00.0 Host bridge: Intel Corporation 3rd Gen Core processor DRAM Controller (rev 09)
00:01.0 PCI bridge: Intel Corporation Xeon E3-1200 v2/3rd Gen Core processor PCI Express Root Port (rev 09)
00:02.0 VGA compatible controller: Intel Corporation 3rd Gen Core processor Graphics Controller (rev 09)
00:14.0 USB controller: Intel Corporation 7 Series/C210 Series Chipset Family USB xHCI Host Controller (rev 04)
00:16.0 Communication controller: Intel Corporation 7 Series/C216 Chipset Family MEI Controller #1 (rev 04)
00:1a.0 USB controller: Intel Corporation 7 Series/C216 Chipset Family USB Enhanced Host Controller #2 (rev 04)
00:1b.0 Audio device: Intel Corporation 7 Series/C216 Chipset Family High Definition Audio Controller (rev 04)
00:1c.0 PCI bridge: Intel Corporation 7 Series/C216 Chipset Family PCI Express Root Port 1 (rev c4)
00:1c.2 PCI bridge: Intel Corporation 7 Series/C210 Series Chipset Family PCI Express Root Port 3 (rev c4)
00:1c.3 PCI bridge: Intel Corporation 7 Series/C216 Chipset Family PCI Express Root Port 4 (rev c4)
00:1c.5 PCI bridge: Intel Corporation 7 Series/C210 Series Chipset Family PCI Express Root Port 6 (rev c4)
00:1d.0 USB controller: Intel Corporation 7 Series/C216 Chipset Family USB Enhanced Host Controller #1 (rev 04)
00:1f.0 ISA bridge: Intel Corporation HM76 Express Chipset LPC Controller (rev 04)
00:1f.2 SATA controller: Intel Corporation 7 Series Chipset Family 6-port SATA Controller [AHCI mode] (rev 04)
01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Thames [Radeon HD 7550M/7570M/7650M] (rev ff)
03:00.0 System peripheral: JMicron Technology Corp. SD/MMC Host Controller (rev 30)
03:00.2 SD Host controller: JMicron Technology Corp. Standard SD Host Controller (rev 30)
03:00.3 System peripheral: JMicron Technology Corp. MS Host Controller (rev 30)
04:00.0 Network controller: Ralink corp. RT3290 Wireless 802.11n 1T/1R PCIe
04:00.1 Bluetooth: Ralink corp. RT3290 Bluetooth
05:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 07)