Bug 201351

Created attachment 278969 [details]
acpi dump output from Fedora's 4.18.7 kernel

Please attach the dmesg of the new kernel and older kernel

Created attachment 279039 [details]
Dmesg output for 4.16.14

Created attachment 279041 [details]
Dmesg output for 4.18.13

I've attacjed dmesg output for Fedora's 4.16.14 and 4.18.13. I don't have 4.18.7 on my system anymore. I've been updating as Fedora iterates on their kernels in hopes of finding that the problem has gone away.

Created attachment 279053 [details]
load ecdt at the same time regardless of execute table as method

Give this a try. It seemed to fix a macbook pro issue. Please note that this is not a valid fix.. It's only to test whether if your bug is similar to https://bugzilla.kernel.org/show_bug.cgi?id=200011

(In reply to Charles Stanhope from comment #4)
> Created attachment 279041 [details]
> Dmesg output for 4.18.13
> 
> I've attacjed dmesg output for Fedora's 4.16.14 and 4.18.13. I don't have
> 4.18.7 on my system anymore. I've been updating as Fedora iterates on their
> kernels in hopes of finding that the problem has gone away.

It would be great if you could try to build and boot 4.19-rc8 with the patch from comment 5. I think it would be valuable for us to test this. I've seen something similar on a macbook pro.  Let me know if you need any help with this. I would be more than happy to point you to resources.

Erik, I apologize for my slow response. I'll do my best to try your suggestion this weekend.

Created attachment 279111 [details]
Dmesg output for 4.19-rc8 with patch applied

I was able to try the kernel with the supplied patch. I was indeed able to both read the battery status and suspend the machine by closing the lid. I'm attaching the dmesg output with this kernel and patch in case it is useful. I'm happy to try anything else you might suggest.

So this patch helps solve your problem.. Unfortunately we can't upstream this. We need to somehow make this work without this patch... There may be some other issue in linux kernel ec driver. I'll get back to you soon on the next steps..

Please try 4.20-rc1 when it releases

Hello, 4.20-rc1 is out now so go ahead and give it a try. I've asked Rui to take a look at this bug because it seems like an issue with the EC driver. Please try it and let us know if the issue persists.

Created attachment 279369 [details]
Dmesg dump from 4.20-rc1

Thank you for the heads up about the tag. I just tested out 4.20-rc1, and I am seeing the same behavior as before: incorrect battery reading, and the laptop lid switch isn't working.

So, first of all, please make sure your kernel is built with CONFIG_ACPI_DEBUG=Y, and then boot with kernel parameter "acpi.debug_level=0x420 acpi.debug_layer=0x05", and attach the full dmesg output after boot, for both good and bad kernels.

Created attachment 279665 [details]
custom dsdt to dump bat and lid status

please apply this customized DSDT and attach
1. output of "grep . /sys/class/power_supply/*/*"
2. dmesg output after step 1
for both good and bad kernels.

Created attachment 279809 [details]
Dmesg output for 4.20-rc1 with acpi.debug_level=0x420 and acpi.debug_layer=0x05

Created attachment 279811 [details]
Dmesg dump from 4.16.0-rc2 (good) with acpi.debug_level=0x420 and acpi.debug_layer=0x05

I've attached dmesg outputs for the 4.20-rc1 kernel and a 4.16.0-rc2 (7decc66df940f) kernel with the requested kernel boot parameters. The 4.16.0-rc2 came just before the bisection result and appears to be "good". 

I've attempted to apply the dsdt in two ways. I first tried using a cpio file passed at boot time using instructions I found on the Arch wiki[0]. I was attempting to avoid compiling the kernel since I only have a little time to work on things today. (I converted the source code in the .hex to an aml file with some scripting.) I did this while I was waiting for a kernel build. As far as I can tell, this didn't seem to work. There was no kernel message indicating an override.

After the kernel finished building, I also attempted to apply the dsdt in the way probably intended by compiling it in the kernel. However, I am getting compile errors after attempting to configure the kernel build using instructions I found here at the arch wiki and the Intel open source site[1]:

 CC      drivers/acpi/tables.o                                     
drivers/acpi/tables.c: In function ‘acpi_os_table_override’:     
drivers/acpi/tables.c:722:44: error: ‘AmlCode’ undeclared (first use in this function)
   *new_table = (struct acpi_table_header *)AmlCode;                
                                            ^~~~~~~

This was with the 4.16.0-rc2 kernel I used to provide the dmesg output. I can try other commits to see if I have better luck, but it will probably be a little while before I can do that.

[0] https://wiki.archlinux.org/index.php/DSDT
[1] https://01.org/linux-acpi/documentation/overriding-dsdt

please confirm if the problem is gone with the patch at https://bugzilla.kernel.org/show_bug.cgi?id=200011#c71

I confirm. With 4.20.0-rc2 and the above linked patch, the problem goes away. Without the patch, I have the same bugs as before.

please confirm if the patch at https://bugzilla.kernel.org/show_bug.cgi?id=199981#c34 helps or not

I applied the patch https://bugzilla.kernel.org/show_bug.cgi?id=199981#c34 to the same 4.20.0-rc2 as before (after backing out any other patches), and it does enable the battery status and the lid switch.

*** This bug has been marked as a duplicate of bug 199981 ***

here is the latest patch,
https://patchwork.kernel.org/patch/10753143/
please apply it on top of 5.0-rc1 and check if it works or not.

I applied the patch to 5.0-rc1 and tested. It fixes the battery status and lid switch issue. :)